Skip to content

Commit 796756e

Browse files
samukwekuericmjl
andauthored
[ENH] fix bug pivot_longer (#828)
* fix bug pivot_longer * minor edit * xfail for finance/test_convert_currency * stop execution of inflate_currency notebook * stop execution inflation_currency notebook * test nbsphinx stop notebook execution again * test non execution * fix flake8 error * fixed flake8 errors * Edit configuration to exclude the currency inflation notebook. * One more try avoiding the inflating_converting_currency notebook. * Add comment why that notebook was specifically excluded * Disable convert currency. * Completed out the underscore for italicization. * Add in docstrings. * Update changelog. * Address @jk3587's comment on "hit" vs "call" * Update conftest for spark. Co-authored-by: Eric Ma <[email protected]>
1 parent 081f249 commit 796756e

File tree

7 files changed

+406
-393
lines changed

7 files changed

+406
-393
lines changed

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
# Changelog
22

33
## [Unreleased]
4-
- drop `fill_value` parameter from `complete`. Users can use `fillna` instead. @samukweku
4+
5+
- [ENH] Drop `fill_value` parameter from `complete`. Users can use `fillna` instead. @samukweku
6+
- [BUG] Fix bug in `pivot_longer` with single level columns. @samukweku
7+
- [BUG] Disable exchange rates API until we can find another one to hit. @ericmjl
58

69
## [v0.20.14] - 2021-03-25
710

docs/conf.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
# -- Path setup --------------------------------------------------------------
1212

1313
import datetime
14+
1415
# If extensions (or modules to document with autodoc) are in another directory,
1516
# add these directories to sys.path here. If the directory is relative to the
1617
# documentation root, use os.path.abspath to make it absolute, like shown here.
@@ -45,7 +46,7 @@
4546
now = datetime.datetime.now()
4647
CurrentYear = str(now.year)
4748
copyright = CurrentYear + ", PyJanitor devs"
48-
author = "Eric J. Ma"
49+
author = "pyjanitor devs"
4950

5051
# The short X.Y version
5152
version = "0.1.0"
@@ -97,7 +98,13 @@
9798
# List of patterns, relative to source directory, that match files and
9899
# directories to ignore when looking for source files.
99100
# This pattern also affects html_static_path and html_extra_path .
100-
exclude_patterns = ["_build", "Thumbs.db", ".DS_Store", "**.ipynb_checkpoints"]
101+
exclude_patterns = [
102+
"_build",
103+
"Thumbs.db",
104+
".DS_Store",
105+
"**.ipynb_checkpoints",
106+
"inflating_converting_currency*", # not working on PR #828.
107+
]
101108

102109
# The name of the Pygments (syntax highlighting) style to use.
103110
pygments_style = "sphinx"
@@ -215,3 +222,4 @@
215222
# -- Other options -----------------------------------------------------------
216223

217224
autosummary_generate = True # Make _autosummary files and include them
225+
nbsphinx_execute = "never"

examples/notebooks/inflating_converting_currency.ipynb

Lines changed: 108 additions & 155 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)