update to tests

Author: samukweku

tests/functions/test_conditional_join.py

@@ -833,17 +833,18 @@ def test_dual_conditions_eq_and_ne(df, right):
         .query(f"{eq_A} == {eq_B} and {ne_A} != {ne_B}")
         .reset_index(drop=True)
     )
-    expected = expected.filter([eq_A, eq_B, ne_A, ne_B])
+    # nulls are not preserved for multiple conditions
+    # that involve `!=`
+    expected = expected.filter([eq_A, eq_B, ne_A, ne_B]).dropna()
     actual = df.conditional_join(
         right,
         (eq_A, eq_B, "=="),
         (ne_A, ne_B, "!="),
         how="inner",
         sort_by_appearance=True,
     )
-    # nulls are not preserved for multiple conditions
-    # that involve `!=`
-    actual = actual.filter([eq_A, eq_B, ne_A, ne_B]).dropna()
+
+    actual = actual.filter([eq_A, eq_B, ne_A, ne_B])
     assert_frame_equal(actual, actual)
 
 
@@ -861,15 +862,16 @@ def test_dual_conditions_ne_and_eq(df, right):
         .query(f"{eq_A} != {eq_B} and {ne_A} == {ne_B}")
         .reset_index(drop=True)
     )
-    expected = expected.filter([eq_A, eq_B, ne_A, ne_B])
+    # nulls are not preserved for multiple conditions
+    # that involve `!=`
+    expected = expected.filter([eq_A, eq_B, ne_A, ne_B]).dropna()
     actual = df.conditional_join(
         right,
         (eq_A, eq_B, "!="),
         (ne_A, ne_B, "=="),
         how="inner",
         sort_by_appearance=True,
     )
-    # nulls are not preserved for multiple conditions
-    # that involve `!=`
-    actual = actual.filter([eq_A, eq_B, ne_A, ne_B]).dropna()
+
+    actual = actual.filter([eq_A, eq_B, ne_A, ne_B])
     assert_frame_equal(expected, actual)