Fix consider-using-augmented-assign nested attribute access

Author: cdce8p

doc/whatsnew/fragments/8086.false_positive

@@ -0,0 +1,3 @@
+Fix ``consider-using-augmented-assign`` checker for nested attribute access.
+
+Closes #8086

pylint/checkers/utils.py

@@ -2066,22 +2066,6 @@ def is_hashable(node: nodes.NodeNG) -> bool:
         return True
 
 
-def get_full_name_of_attribute(node: nodes.Attribute | nodes.AssignAttr) -> str:
-    """Return the full name of an attribute and the classes it belongs to.
-
-    For example: "Class1.Class2.attr"
-    """
-    parent = node.parent
-    ret = node.attrname or ""
-    while isinstance(parent, (nodes.Attribute, nodes.Name)):
-        if isinstance(parent, nodes.Attribute):
-            ret = f"{parent.attrname}.{ret}"
-        else:
-            ret = f"{parent.name}.{ret}"
-        parent = parent.parent
-    return ret
-
-
 def _is_target_name_in_binop_side(
     target: nodes.AssignName | nodes.AssignAttr, side: nodes.NodeNG | None
 ) -> bool:
@@ -2091,7 +2075,7 @@ def _is_target_name_in_binop_side(
             return target.name == side.name  # type: ignore[no-any-return]
         return False
     if isinstance(side, nodes.Attribute) and isinstance(target, nodes.AssignAttr):
-        return get_full_name_of_attribute(target) == get_full_name_of_attribute(side)
+        return target.as_string() == side.as_string()  # type: ignore[no-any-return]
     return False
 
 

tests/functional/ext/code_style/cs_consider_using_augmented_assign.py

@@ -1,6 +1,6 @@
 """Tests for consider-using-augmented-assign."""
 
-# pylint: disable=invalid-name,too-few-public-methods,import-error,consider-using-f-string
+# pylint: disable=invalid-name,too-few-public-methods,import-error,consider-using-f-string,missing-docstring
 
 from unknown import Unknown
 
@@ -119,3 +119,17 @@ def return_str() -> str:
 
 x = x <= 3
 x = 3 <= x
+
+
+# https://github.com/PyCQA/pylint/issues/8086
+# consider-using-augmented-assign should only be flagged
+# if names attribute names match exactly.
+
+class A:
+    def __init__(self) -> None:
+        self.a = 1
+        self.b = A()
+
+    def test(self) -> None:
+        self.a = self.a + 1  # [consider-using-augmented-assign]
+        self.b.a = self.a + 1  # Names don't match!

tests/functional/ext/code_style/cs_consider_using_augmented_assign.txt

@@ -24,3 +24,4 @@ consider-using-augmented-assign:104:0:104:9::Use '&=' to do an augmented assign
 consider-using-augmented-assign:105:0:105:9::Use '&=' to do an augmented assign directly:INFERENCE
 consider-using-augmented-assign:108:0:108:9::Use '|=' to do an augmented assign directly:INFERENCE
 consider-using-augmented-assign:109:0:109:9::Use '|=' to do an augmented assign directly:INFERENCE
+consider-using-augmented-assign:134:8:134:27:A.test:Use '+=' to do an augmented assign directly:INFERENCE