Skip to content

Commit 5b109b4

Browse files
author
Or Bahari
committed
empty-comment line number bug fix
1 parent f95bbac commit 5b109b4

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

ChangeLog

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
------------------
22
Pylint's ChangeLog
33
------------------
4+
* Bug fix for empty-comment message line number.
5+
6+
Closes #4009
7+
48
* Only emit `bad-reversed-sequence` on dictionaries if below py3.8
59

610
Closes #3940

pylint/extensions/empty_comment.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def process_module(self, node):
4949
line = line.rstrip()
5050
if line.endswith(b"#"):
5151
if not is_line_commented(line[:-1]):
52-
self.add_message("empty-comment", line=line_num)
52+
self.add_message("empty-comment", line=line_num + 1)
5353

5454

5555
def register(linter):

tests/extensions/test_empty_comment.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def test_comment_base_case(linter):
2828
for msg in msgs:
2929
assert msg.symbol == "empty-comment"
3030
assert msg.msg == "Line with empty comment"
31-
assert msgs[0].line == 1
32-
assert msgs[1].line == 2
33-
assert msgs[2].line == 4
34-
assert msgs[3].line == 6
31+
assert msgs[0].line == 2
32+
assert msgs[1].line == 3
33+
assert msgs[2].line == 5
34+
assert msgs[3].line == 7

0 commit comments

Comments
 (0)