Skip to content

Commit 37765ff

Browse files
committed
fixup! avoid duplication of dist lookup
1 parent d31e805 commit 37765ff

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/pip/_internal/commands/index.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from pip._internal.cli.status_codes import ERROR, SUCCESS
1111
from pip._internal.commands.search import (
1212
get_installed_distribution,
13-
print_dist_installation_info_if_exists,
13+
print_dist_installation_info,
1414
)
1515
from pip._internal.exceptions import CommandError, DistributionNotFound, PipError
1616
from pip._internal.index.collector import LinkCollector
@@ -156,4 +156,4 @@ def get_available_package_versions(self, options: Values, args: List[Any]) -> No
156156
else:
157157
write_output(f"{query} ({latest})")
158158
write_output("Available versions: {}".format(", ".join(formatted_versions)))
159-
print_dist_installation_info_if_exists(latest, dist)
159+
print_dist_installation_info(latest, dist)

src/pip/_internal/commands/search.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,7 @@ def transform_hits(hits: List[Dict[str, str]]) -> List["TransformedHit"]:
112112
return list(packages.values())
113113

114114

115-
def print_dist_installation_info_if_exists(
116-
latest: str, dist: Optional[BaseDistribution]
117-
) -> None:
115+
def print_dist_installation_info(latest: str, dist: Optional[BaseDistribution]) -> None:
118116
if dist is not None:
119117
with indent_log():
120118
if dist.version == latest:
@@ -170,7 +168,7 @@ def print_results(
170168
try:
171169
write_output(line)
172170
dist = get_installed_distribution(name)
173-
print_dist_installation_info_if_exists(latest, dist)
171+
print_dist_installation_info(latest, dist)
174172
except UnicodeEncodeError:
175173
pass
176174

0 commit comments

Comments
 (0)