Skip to content

Commit f0b2e2e

Browse files
malfetfacebook-github-bot
authored andcommitted
Get rid of tautological check (#225)
Summary: `daemonConfigLoaderFactory` is a function and therefore always non-null Fixes following clang warning: ``` ../third_party/kineto/libkineto/src/ConfigLoader.cpp:161:7: warning: address of function 'daemonConfigLoaderFactory' will always evaluate to 'true' [-Wpointer-bool-conversion] if (daemonConfigLoaderFactory && daemonConfigLoaderFactory()) { ^~~~~~~~~~~~~~~~~~~~~~~~~ ~~ ``` Pull Request resolved: #225 Reviewed By: ilia-cher Differential Revision: D28405389 Pulled By: malfet fbshipit-source-id: 3930ab1acd6f2909602eada246d9ad01d9a923e3
1 parent a631215 commit f0b2e2e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

libkineto/src/ConfigLoader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ ConfigLoader::ConfigLoader(LibkinetoApi& api)
158158
config_.parse(readConfigFromConfigFile(configFileName_));
159159
SET_LOG_VERBOSITY_LEVEL(config_.verboseLogLevel(), config_.verboseLogModules());
160160
setupSignalHandler(config_.sigUsr2Enabled());
161-
if (daemonConfigLoaderFactory && daemonConfigLoaderFactory()) {
161+
if (daemonConfigLoaderFactory()) {
162162
daemonConfigLoader_ = daemonConfigLoaderFactory()();
163163
daemonConfigLoader_->setCommunicationFabric(config_.ipcFabricEnabled());
164164
}

0 commit comments

Comments
 (0)