Skip to content

Commit ff763d4

Browse files
kausvfacebook-github-bot
authored andcommitted
set DDR size in planner to 0
Summary: DDR memory for KV ZCH (Virtual Tables) is stilll WiP. We are setting it to 0 temporarily while we determine the right way to estimate it Differential Revision: D76146650
1 parent 515b97b commit ff763d4

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

torchrec/distributed/planner/shard_estimators.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1245,7 +1245,8 @@ def calculate_shard_storages(
12451245
for _ in hbm_specific_sizes
12461246
]
12471247
ddr_specific_sizes = [
1248-
(key_value_params.l2_cache_size or 0) * 1024 * 1024 * 1024
1248+
# TODO: revisit the logic for SSD virtual table
1249+
0
12491250
for _ in ddr_specific_sizes
12501251
]
12511252

torchrec/distributed/planner/tests/test_planners.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,7 @@ def test_planner_with_virtual_table(self) -> None:
618618
# L1 cache size is 64GB per shard and L2 cache size is 128MB per shard per table
619619
self.assertTrue(
620620
any(
621-
"dram_virtual_table: HBM: 0.501 GB, DDR: 256.0 GB" in line
621+
"dram_virtual_table: HBM: 0.501 GB, DDR: 0.0 GB" in line
622622
for line in stats
623623
)
624624
)
@@ -748,7 +748,7 @@ def test_planner_with_virtual_table(self) -> None:
748748
# L2 cache size is 128MB per shard per table
749749
self.assertTrue(
750750
any(
751-
"dram_virtual_table: HBM: 0.002 GB, DDR: 256.0 GB" in line
751+
"dram_virtual_table: HBM: 0.002 GB, DDR: 0.0 GB" in line
752752
for line in stats
753753
)
754754
)
@@ -800,7 +800,7 @@ def test_planner_with_virtual_table(self) -> None:
800800
# L2 cache size is 128MB per shard per table
801801
self.assertTrue(
802802
any(
803-
"dram_virtual_table: HBM: 0.005 GB, DDR: 256.0 GB" in line
803+
"dram_virtual_table: HBM: 0.005 GB, DDR: 0.0 GB" in line
804804
for line in stats
805805
)
806806
)

0 commit comments

Comments
 (0)