Skip to content

set DDR size in planner to 0 #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kausv
Copy link
Contributor

@kausv kausv commented Jun 6, 2025

Summary:
DDR memory for KV ZCH (Virtual Tables) is stilll WiP.
We are setting it to 0 temporarily while we determine the right way to estimate it

Differential Revision: D76146650

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76146650

@kausv kausv force-pushed the export-D76146650 branch from ff763d4 to a8d5209 Compare June 9, 2025 12:56
kausv added a commit to kausv/torchrec that referenced this pull request Jun 9, 2025
Summary:

DDR memory for KV ZCH (Virtual Tables) is stilll WiP.
We are setting it to 0 temporarily while we determine the right way to estimate it

Differential Revision: D76146650
Summary:
Pull Request resolved: pytorch#3052

DDR memory for KV ZCH (Virtual Tables) is stilll WiP.
We are setting it to 0 temporarily while we determine the right way to estimate it

Differential Revision: D76146650
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76146650

@kausv kausv force-pushed the export-D76146650 branch from a8d5209 to 912169b Compare June 9, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants