Invalid Scheduler Exception (#513)

scottilee · facebook-github-bot · commit 42e9b44adac1 · 2022-06-09T15:35:15.000-07:00
Summary: Pull Request resolved: #513 Fixes #512 which reports an KeyError thrown when providing an invalid scheduler to the torchx CLI. Reviewed By: kiukchung Differential Revision: D37043441 fbshipit-source-id: 2a346138356e7c6b62e9b298c41ce8fb35f02865
diff --git a/torchx/cli/cmd_run.py b/torchx/cli/cmd_run.py
@@ -123,6 +123,7 @@ def add_arguments(self, subparser: argparse.ArgumentParser) -> None:
             "--scheduler",
             type=str,
             default=get_default_scheduler_name(),
+            choices=list(scheduler_names),
             action=torchxconfig_run,
             help=f"Name of the scheduler to use. One of: [{','.join(scheduler_names)}]",
         )

Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,7 @@ def add_arguments(self, subparser: argparse.ArgumentParser) -> None:`
`123`	`123`	`"--scheduler",`
`124`	`124`	`type=str,`
`125`	`125`	`default=get_default_scheduler_name(),`
	`126`	`+ choices=list(scheduler_names),`
`126`	`127`	`action=torchxconfig_run,`
`127`	`128`	`help=f"Name of the scheduler to use. One of: [{','.join(scheduler_names)}]",`
`128`	`129`	`)`