Skip to content

Commit c56cad6

Browse files
mpolson64facebook-github-bot
authored andcommitted
Correct TorchXScheduler.poll_trial_status signature
Summary: A change in core Ax's scheduler API caused this bug downstream D32762724. Currently TorchXScheduler just ignores the new option, and its default valued so this should just fix everything out of the box, but the torchx folks may or may not want to go ahead and implement the expected associated behavior in the future. This was surfaced to me by a bisect Reviewed By: d4l3k Differential Revision: D32919059 fbshipit-source-id: 0fa57ed957acc090a615eb6da37ef525c88a0b0e
1 parent 1492c17 commit c56cad6

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

torchx/runtime/hpo/ax.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,9 @@ class TorchXScheduler(ax_Scheduler):
219219
220220
"""
221221

222-
def poll_trial_status(self) -> Dict[TrialStatus, Set[int]]:
222+
def poll_trial_status(
223+
self, poll_all_trial_statuses: bool = False
224+
) -> Dict[TrialStatus, Set[int]]:
223225
trial_statuses: Dict[TrialStatus, Set[int]] = {}
224226

225227
for trial in self.running_trials:

0 commit comments

Comments
 (0)