Skip to content

Destination missing when built with custom route override #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janseeger opened this issue Mar 24, 2025 · 2 comments
Open

Destination missing when built with custom route override #729

janseeger opened this issue Mar 24, 2025 · 2 comments
Labels
feedback needed Extra attention is needed

Comments

@janseeger
Copy link

I am currently migrating code from v1 (1.11.9) to v2 (2.1.0) and have encountered an issue where some Destinations are not built and are thus missing after the KSP ran.

@Destination(
    route = "inbox",
    deepLinks = [
        DeepLink(uriPattern = PREFIX_URI1 + FULL_ROUTE_PLACEHOLDER),
        DeepLink(uriPattern = PREFIX_URI2 + FULL_ROUTE_PLACEHOLDER),
    ],
)
@Composable
fun InboxWithMoreComplexNameThanJustInbox()

works and generates the correct code, but when converted to v2

@Destination<InboxGraph>(
    route = "inbox",
    deepLinks = [
        DeepLink(uriPattern = PREFIX_URI1 + FULL_ROUTE_PLACEHOLDER),
        DeepLink(uriPattern = PREFIX_URI2 + FULL_ROUTE_PLACEHOLDER),
    ],
)

it stops working unless the route parameter is removed. But then the Deep Links stop working.

Any advice?

@raamcosta
Copy link
Owner

Are you seeing anything else? or it simply gets ignored?

Can you try using any other route? Just a random one? Does it work then?

@raamcosta raamcosta added the feedback needed Extra attention is needed label May 1, 2025
@janseeger
Copy link
Author

It does occur with several of the Routes, every time I override the route parameter with any value this specific Destination is then not built, while the others without the parameter are present and working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback needed Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants