Skip to content

Target Redis server version #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lewispb opened this issue Feb 28, 2022 · 2 comments
Closed

Target Redis server version #77

lewispb opened this issue Feb 28, 2022 · 2 comments

Comments

@lewispb
Copy link
Contributor

lewispb commented Feb 28, 2022

While working on a feature recently I was exploring the use of the ZADD options GT and LT. These are only available in Redis 6.2 onwards.

Do we have a minimum Redis server version in mind while developing Kredis? If not, can we document one?

The only reference to a version I could see was this line: https://github.com/rails/kredis/blob/main/lib/kredis/migration.rb#L8

@dhh
Copy link
Member

dhh commented Feb 28, 2022

I believe we're at Redis 4+ at the moment since that's what Rails suggest in the default Gemfile.

But we probably could just gate new features on a redis version check? Then fail if not available?

@lewispb
Copy link
Contributor Author

lewispb commented Mar 1, 2022

Added a note to the readme in #79.

I backed away from GT / LT so nothing in mind that would require gating right now, but good to know that's an option for the future.

Might be worth also adding a matrix of supported Redis server versions, say 4 and 6.2, and client libraries to CI?

@dhh dhh closed this as completed Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants