Skip to content

Commit 4779fb8

Browse files
authored
fix: tagRender should not be called when value is empty (#1109)
1 parent fa18f57 commit 4779fb8

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

src/Selector/MultipleSelector.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,10 @@ const SelectSelector: React.FC<SelectorProps> = (props) => {
188188
};
189189

190190
const renderRest = (omittedValues: DisplayValueType[]) => {
191+
// https://github.com/ant-design/ant-design/issues/48930
192+
if (!values.length) {
193+
return null;
194+
}
191195
const content =
192196
typeof maxTagPlaceholder === 'function'
193197
? maxTagPlaceholder(omittedValues)

tests/Tags.test.tsx

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,20 @@ describe('Select.Tags', () => {
323323
});
324324
});
325325

326+
// https://github.com/ant-design/ant-design/issues/48930
327+
it('should not call tagRender when value is empty', () => {
328+
const tagRender = jest.fn();
329+
render(
330+
<Select
331+
mode="tags"
332+
value={[]}
333+
tagRender={tagRender}
334+
options={[{ value: 'light' }, { value: 'dark' }]}
335+
/>,
336+
);
337+
expect(tagRender).not.toHaveBeenCalled();
338+
});
339+
326340
it('disabled', () => {
327341
const tagRender = jest.fn();
328342
render(

0 commit comments

Comments
 (0)