Skip to content

Commit e4eb626

Browse files
committed
Keep variable name on assert_react_component props.
We need make sure the prop name is correct, because JavaScript used that it's case sensitive.
1 parent 5f48674 commit e4eb626

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

lib/react/rails/test_helper.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ def assert_react_component(name)
1212
assert_select "div[data-react-class=?]", name do |dom|
1313
if block_given?
1414
props = JSON.parse(dom.attr("data-react-props"))
15-
props.deep_transform_keys! { |key| key.to_s.underscore }
1615
props.deep_symbolize_keys!
1716

1817
yield(props)

test/dummy_webpacker1/app/views/pages/show.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
</ul>
55

66
<div id='component-parent'>
7-
<%= react_component 'GreetingMessage', { name: @name, last_name: "Last #{@name}", info: { name: @name } }, { id: 'component', class: "greeting-message", prerender: @prerender } %>
7+
<%= react_component 'GreetingMessage', { name: @name, lastName: "Last #{@name}", info: { name: @name, lastName: "Last #{@name}" } }, { id: 'component', class: "greeting-message", prerender: @prerender } %>
88
<ul>
99
<%= react_component 'Todo', { todo: 'Another Component' }, { id: 'todo', prerender: @prerender } %>
1010
</ul>

test/dummy_webpacker2/app/views/pages/show.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
</ul>
55

66
<div id='component-parent'>
7-
<%= react_component 'GreetingMessage', { name: @name, last_name: "Last #{@name}", info: { name: @name } }, { id: 'component', class: "greeting-message", prerender: @prerender } %>
7+
<%= react_component 'GreetingMessage', { name: @name, lastName: "Last #{@name}", info: { name: @name, lastName: "Last #{@name}" } }, { id: 'component', class: "greeting-message", prerender: @prerender } %>
88
<ul>
99
<%= react_component 'Todo', { todo: 'Another Component' }, { id: 'todo', prerender: @prerender } %>
1010
</ul>

test/dummy_webpacker3/app/views/pages/show.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
</ul>
55

66
<div id='component-parent'>
7-
<%= react_component 'GreetingMessage', { name: @name, last_name: "Last #{@name}", info: { name: @name } }, { id: 'component', class: "greeting-message", prerender: @prerender } %>
7+
<%= react_component 'GreetingMessage', { name: @name, lastName: "Last #{@name}", info: { name: @name, lastName: "Last #{@name}" } }, { id: 'component', class: "greeting-message", prerender: @prerender } %>
88
<ul>
99
<%= react_component 'Todo', { todo: 'Another Component' }, { id: 'todo', prerender: @prerender } %>
1010
</ul>

test/react/rails/test_helper_test.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ class TestHelperTest < ActionDispatch::IntegrationTest
1111
assert_react_component "GreetingMessage"
1212
assert_react_component "GreetingMessage" do |props|
1313
assert_equal "Bob", props[:name]
14-
assert_equal "Last Bob", props[:last_name]
14+
assert_equal "Last Bob", props[:lastName]
1515
assert_equal "Bob", props[:info][:name]
16+
assert_equal "Last Bob", props[:info][:lastName]
1617

1718
assert_select "[id=?]", "component"
1819
assert_select "[class=?]", "greeting-message"

0 commit comments

Comments
 (0)