-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: support vectorset #3375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: support vectorset #3375
Conversation
Thank you @fukua95, will review as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left two comments, this is just a partial review.
@fukua95 we will have a discussion next week, overall I think the PR looks good, if the team agrees on the return types, I will merge this, thank you. |
Thank you for your review. If there is anything that needs to be updated (the return types or others), please feel free to let me know. One more thing: The |
Signed-off-by: fukua95 <[email protected]>
@fukua95 we are still not set on the return types, but one thing I will suggest is to use something similar to go-redis/sortedset_commands.go Line 728 in 27581fc
|
Using a struct is more user-friendly. I will update it soon. |
vectorset commands: https://redis.io/docs/latest/develop/data-types/vector-sets/