Skip to content

Introduce a common interface or base class among Pipeline and multi node pipeline classes #3220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sazzad16 opened this issue Nov 30, 2022 · 1 comment · Fixed by #3437
Closed
Milestone

Comments

@sazzad16
Copy link
Contributor

sazzad16 commented Nov 30, 2022

Concerned methods:

  • sync()
  • close()
@sazzad16 sazzad16 added this to the 5.0.0 milestone Nov 30, 2022
@sazzad16
Copy link
Contributor Author

Currently, Pipeline already extends Queable which is common with Transaction classes. Because we can't extend more than once, right now it is not possible to simply create PipelineBase class and extend from Pipeline. Now, perhaps, it is more important to share a common PipelineBase among Pipeline and multi node pipeline classes than to share Queable among Pipeline and Transaction classes.

@sazzad16 sazzad16 added breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. maintenance and removed discussion needed labels May 24, 2023
@sazzad16 sazzad16 removed the breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant