Skip to content

Fail with Python 3.12 #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shadchin opened this issue Jun 29, 2024 · 8 comments
Closed

Fail with Python 3.12 #3299

shadchin opened this issue Jun 29, 2024 · 8 comments
Assignees

Comments

@shadchin
Copy link

Version: last version 5.0.7

Platform: all platforms

Description:

Fail import redis.commands.graph with Python 3.12+

(venv312) shadchin@jakku:~/venv312/bin$ python -c 'import redis.commands.graph'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/shadchin/venv312/lib/python3.12/site-packages/redis/commands/graph/__init__.py", line 4, in <module>
    from .commands import AsyncGraphCommands, GraphCommands
  File "/home/shadchin/venv312/lib/python3.12/site-packages/redis/commands/graph/commands.py", line 6, in <module>
    from .query_result import AsyncQueryResult, QueryResult
  File "/home/shadchin/venv312/lib/python3.12/site-packages/redis/commands/graph/query_result.py", line 3, in <module>
    from distutils.util import strtobool
ModuleNotFoundError: No module named 'distutils'
@gerzse
Copy link
Contributor

gerzse commented Jul 3, 2024

@shadchin Please note that Python 3.12 is not yet supported in redis-py. Work is in progress on this. Can you try 3.11 in the meanwhile?

@shadchin
Copy link
Author

shadchin commented Jul 4, 2024

It's not blocking me yet, I just decided to let you know, in case you didn't know

@AniaKru95
Copy link

I would like to know, when are you planning compatibility implementation with Python 3.12?

@rtaycher
Copy link

rtaycher commented Feb 11, 2025

3.12 is listed as supported in setup.py/pypi. Is that accurate? If so can we close this ticket?

@rtaycher
Copy link

3.13 installs and imports

On the other hand some parts of tests fail at least locally (might be my setup (also pytest-profiling needs to be updated to 1.8.1 to replace the removed pipes library)

Can we declare 3.13 supported? If not what needs to be done for it to be supported?
Should I open another ticket?

@petyaslavova petyaslavova self-assigned this Feb 11, 2025
@petyaslavova
Copy link
Collaborator

Hi @rtaycher, I'll check the compatibility with 3.12. If it works without errors, this issue should be closed as it is related to 3.12. For 3.13 support, I suggest opening a new issue to track the request.

@rtaycher
Copy link

3.13 ticket #3501 (comment)

@petyaslavova
Copy link
Collaborator

Half of the pipeline actions are running with Python 3.12 so the compatibility has been fixed. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants