deprecate method keyword #385
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #385 +/- ##
==========================================
- Coverage 98.73% 98.24% -0.49%
==========================================
Files 16 17 +1
Lines 1423 1427 +4
==========================================
- Hits 1405 1402 -3
- Misses 18 25 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort . && black . && flake8whats-new.rstThis
methodkeyword from themask*methodsbackendsetting inregionmask.set_options"rasterize"to"rasterio".As always I am a bit unsure if this is a good idea. Maybe I am just so used to the way it is done. The reason I want to do is that (i) to hide the keyword (ii) the name
methodis misleading. The good thing is that this should barely affect anyone as there is no reason to setmethod="..."(except for testing and rare cases). So I'll mark this as draft and let it sit for some days to get used to it.