reduce changed surfaces

Author: cometkim

CHANGELOG.md

@@ -12,9 +12,9 @@
 
 # 11.1.0-rc.5 (Unreleased)
 
-#### :rocket: New Feature
+#### :nail_care: Polish
 
-- Add bindings to `ArrayBuffer`, `SharedArrayBuffer` and `Atomics`. https://github.com/rescript-lang/rescript-compiler/pull/6683
+- Add `ArrayBuffer.t` and `SharedArrayBuffer.t` to be base types of the Core bindings. https://github.com/rescript-lang/rescript-compiler/pull/6683
 
 # 11.1.0-rc.4
 

jscomp/others/js.ml

@@ -22,7 +22,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 
-[@@@bs.config { flags = [| "-unboxed-types"; "-w"; "-49" |] }]
+[@@@bs.config {flags = [|"-unboxed-types"; "-w"; "-49"|]}]
 (* DESIGN:
    - It does not have any code, all its code will be inlined so that
        there will never be
@@ -82,29 +82,23 @@ module Internal = struct
   external opaqueFullApply : 'a -> 'a = "%uncurried_apply"
 
   (* Use opaque instead of [._n] to prevent some optimizations happening *)
-  external run : (unit -> 'a [@bs]) -> 'a = "#run"
+  external run : ((unit -> 'a)[@bs]) -> 'a = "#run"
   external opaque : 'a -> 'a = "%opaque"
 end
 
 (**/**)
 
-type +'a null =
-  | Value of 'a
-  | Null [@as null]
-[@@unboxed]
 (**
   Nullable value of this type can be either null or 'a. This type is equivalent to Js.Null.t.
 *)
+type +'a null = Value of 'a | Null [@as null] [@@unboxed]
 
 type +'a undefined
 (**
   A value of this type can be either undefined or 'a. This type is equivalent to Js.Undefined.t.
 *)
 
-type +'a nullable =
-  | Value of 'a
-  | Null [@as null]
-  | Undefined [@as undefined]
+type +'a nullable = Value of 'a | Null [@as null] | Undefined [@as undefined]
 [@@unboxed]
 
 (**
@@ -144,17 +138,17 @@ external typeof : 'a -> string = "#typeof"
 *)
 
 external log : 'a -> unit = "log"
-  [@@val] [@@scope "console"]
+[@@val] [@@scope "console"]
 (** Equivalent to console.log any value. *)
 
 external log2 : 'a -> 'b -> unit = "log" [@@bs.val] [@@bs.scope "console"]
 external log3 : 'a -> 'b -> 'c -> unit = "log" [@@bs.val] [@@bs.scope "console"]
 
 external log4 : 'a -> 'b -> 'c -> 'd -> unit = "log"
-  [@@bs.val] [@@bs.scope "console"]
+[@@bs.val] [@@bs.scope "console"]
 
 external logMany : 'a array -> unit = "log"
-  [@@bs.val] [@@bs.scope "console"] [@@bs.splice]
+[@@bs.val] [@@bs.scope "console"] [@@bs.splice]
 (** A convenience function to console.log more than 4 arguments *)
 
 external eqNull : 'a -> 'a null -> bool = "%bs_equal_null"
@@ -199,8 +193,9 @@ module Undefined = Js_undefined
 module Nullable = Js_null_undefined
 (** Provide utilities for `Js.null_undefined` *)
 
-module Null_undefined = Js_null_undefined
-[@deprecated "Please use `Js.Nullable`"]
+module Null_undefined =
+  Js_null_undefined
+  [@deprecated "Please use `Js.Nullable`"]
 
 module Exn = Js_exn
 (** Provide utilities for dealing with Js exceptions *)
@@ -244,21 +239,12 @@ module Math = Js_math
 module Obj = Js_obj
 (** Provide utilities for `Js.t` *)
 
-module ArrayBuffer = Js_array_buffer
-(** Provide utilities for `ArrayBuffer` object *)
-
-module SharedArrayBuffer = Js_shared_array_buffer
-(** Provide utilities for `SharedArrayBuffer` object *)
-
 module Typed_array = Js_typed_array
 (** Provide bindings for JS typed array *)
 
 module TypedArray2 = Js_typed_array2
 (** Provide bindings for JS typed array *)
 
-module Atomics = Js_atomics
-(** Provide bindings for JS `Atomics` utilities *)
-
 module Types = Js_types
 (** Provide utilities for manipulating JS types  *)
 

jscomp/others/js_array_buffer.res

@@ -1,34 +1,6 @@
-@@uncurried
-
-/***
-The underlying buffer that the typed arrays provide views of
-
-**see** [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer)
-*/
 type t = {
   byteLength: int,
   maxByteLength: int,
   detached: bool,
   resizable: bool,
 }
-
-type makeOptions = {
-  maxByteLength?: int
-}
-
-@new /** takes length. initializes elements to 0 */
-external make: (int, makeOptions) => t = "ArrayBuffer"
-let make = (length, ~maxByteLength=?) => make(length, { maxByteLength: ?maxByteLength })
-
-/* ArrayBuffer.isView: seems pointless with a type system */
-
-@get external byteLength: t => int = "byteLength"
-@get external maxByteLength: t => int = "maxByteLength"
-@get external detached: t => bool = "detached"
-@get external resizable: t => bool = "resizable"
-
-@send external slice: (t, ~start: int, ~end_: int) => t = "slice"
-@send external sliceFrom: (t, int) => t = "slice"
-
-@send external transfer: (t, ~newByteLength: int=?) => t = "transfer"
-@send external transferToFixedLength: (t, ~newByteLength: int=?) => t = "transferToFixedLength"

jscomp/others/js_atomics.res

@@ -1,29 +1,5 @@
-@@uncurried
-
-/***
-The underlying buffer that the typed arrays provide views of
-
-**see** [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer)
-*/
 type t = {
   byteLength: int,
   maxByteLength: int,
   growable: bool,
 }
-
-type makeOptions = {
-  maxByteLength?: int
-}
-
-@new /** takes length. initializes elements to 0 */
-external make: (int, makeOptions) => t = "SharedArrayBuffer"
-let make = (length, ~maxByteLength=?) => make(length, { maxByteLength: ?maxByteLength })
-
-/* ArrayBuffer.isView: seems pointless with a type system */
-
-@get external byteLength: t => int = "byteLength"
-@get external maxByteLength: t => int = "maxByteLength"
-@get external growable: t => bool = "growable"
-
-@send external slice: (t, ~start: int, ~end_: int) => t = "slice"
-@send external sliceFrom: (t, int) => t = "slice"