Skip to content

Commit 13a6337

Browse files
committed
Increase MSRV to 1.41.0, as this was when profile-overrides landed
profile-overrides landed in 1.41 rust-lang/cargo#7591 I appreciate that the intention may be to maintain support for earlier rust versions if the profile-overrides keys are deleted from the README. But if the crate throws an error when compiled with its MSRV compiler, that in my opinion defeats the purpose of the MSRV.
1 parent 8a4f9c6 commit 13a6337

File tree

5 files changed

+8
-22
lines changed

5 files changed

+8
-22
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
- x86_64-unknown-linux-gnu
4646
toolchain:
4747
- stable
48-
- 1.36.0
48+
- 1.41.0
4949
steps:
5050
- name: Checkout
5151
uses: actions/checkout@v2
@@ -57,10 +57,6 @@ jobs:
5757
target: ${{ matrix.target }}
5858
override: true
5959

60-
- name: Disable optimisation profiles
61-
if: matrix.toolchain == '1.36.0'
62-
run: sed -i '/^\[profile.*build-override]$/,/^$/{/^#/!{/^$/!d}}' Cargo.toml
63-
6460
- name: cargo check
6561
uses: actions-rs/cargo@v1
6662
with:
@@ -261,7 +257,7 @@ jobs:
261257
- x86_64-unknown-linux-gnu
262258
toolchain:
263259
- stable
264-
- 1.36.0
260+
- 1.41.0
265261
steps:
266262
- name: Checkout
267263
uses: actions/checkout@v2
@@ -272,10 +268,6 @@ jobs:
272268
target: ${{ matrix.target }}
273269
override: true
274270

275-
- name: Disable optimisation profiles
276-
if: matrix.toolchain == '1.36.0'
277-
run: sed -i '/^\[profile.*build-override]$/,/^$/{/^#/!{/^$/!d}}' Cargo.toml
278-
279271
- name: cargo check
280272
uses: actions-rs/cargo@v1
281273
with:
@@ -293,13 +285,10 @@ jobs:
293285
- name: Install Rust
294286
uses: actions-rs/toolchain@v1
295287
with:
296-
toolchain: 1.36.0
288+
toolchain: 1.41.0
297289
target: thumbv7m-none-eabi
298290
override: true
299291

300-
- name: Disable optimisation profiles
301-
run: sed -i '/^\[profile.*build-override]$/,/^$/{/^#/!{/^$/!d}}' Cargo.toml
302-
303292
- uses: actions-rs/cargo@v1
304293
with:
305294
use-cross: false
@@ -316,13 +305,10 @@ jobs:
316305
- name: Install Rust
317306
uses: actions-rs/toolchain@v1
318307
with:
319-
toolchain: 1.36.0
308+
toolchain: 1.41.0
320309
target: thumbv6m-none-eabi
321310
override: true
322311

323-
- name: Disable optimisation profiles
324-
run: sed -i '/^\[profile.*build-override]$/,/^$/{/^#/!{/^$/!d}}' Cargo.toml
325-
326312
- uses: actions-rs/cargo@v1
327313
with:
328314
use-cross: false

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ matrix:
77

88
# MSRV
99
- env: TARGET=thumbv7m-none-eabi
10-
rust: 1.36.0
10+
rust: 1.41.0
1111
if: (branch = staging OR branch = trying) OR (type = pull_request AND branch = master)
1212

1313
- env: TARGET=thumbv6m-none-eabi

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ Formerly known as Real-Time For the Masses.
4141

4242
## Requirements
4343

44-
- Rust 1.36.0+
44+
- Rust 1.41.0+
4545

4646
- Applications must be written using the 2018 edition.
4747

ci/script.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ main() {
5050
fi
5151

5252
if [ $TRAVIS_RUST_VERSION = nightly ]; then
53-
# Tests where required MSRV > 1.36
53+
# Tests where required MSRV > 1.41
5454
#local exs=(
5555
#)
5656
#for ex in ${exs[@]}; do

src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
//!
1818
//! # Minimum Supported Rust Version (MSRV)
1919
//!
20-
//! This crate is guaranteed to compile on stable Rust 1.36 (2018 edition) and up. It *might*
20+
//! This crate is guaranteed to compile on stable Rust 1.41 (2018 edition) and up. It *might*
2121
//! compile on older versions but that may change in any new patch release.
2222
//!
2323
//! # Semantic Versioning

0 commit comments

Comments
 (0)