fix: yaml defaults not loaded in embed (#7301)

* Fix yaml defaults not loaded in embed

* Update comment

Author: AdityaHegde

web-common/src/features/dashboards/state-managers/loaders/DashboardStateDataLoader.ts

@@ -10,6 +10,7 @@ import { getMostRecentPartialExploreState } from "@rilldata/web-common/features/
 import { getExploreStateFromYAMLConfig } from "@rilldata/web-common/features/dashboards/stores/get-explore-state-from-yaml-config";
 import { getRillDefaultExploreState } from "@rilldata/web-common/features/dashboards/stores/get-rill-default-explore-state";
 import type { MetricsExplorerEntity } from "@rilldata/web-common/features/dashboards/stores/metrics-explorer-entity";
+import { cleanEmbedUrlParams } from "@rilldata/web-common/features/dashboards/url-state/clean-url-params";
 import { convertURLSearchParamsToExploreState } from "@rilldata/web-common/features/dashboards/url-state/convertURLSearchParamsToExploreState";
 import { useExploreValidSpec } from "@rilldata/web-common/features/explores/selectors";
 import { queryClient } from "@rilldata/web-common/lib/svelte-query/globalQueryClient";
@@ -241,6 +242,8 @@ export class DashboardStateDataLoader {
     rillDefaultExploreState: MetricsExplorerEntity;
     backButtonUsed: boolean;
   }) {
+    urlSearchParams = cleanEmbedUrlParams(urlSearchParams);
+
     const skipSessionStorage = backButtonUsed;
     const exploreStateFromSessionStorage = skipSessionStorage
       ? null

web-common/src/features/dashboards/url-state/clean-url-params.ts

@@ -40,3 +40,23 @@ export function cleanUrlParams(
   });
   return cleanedParams;
 }
+
+/**
+ * Temporary fix to clean non-dashboard parameters from embed URLs.
+ * When URL parameters exist, they are loaded exclusively from the URL, bypassing dashboard yaml defaults.
+ * Since non-dashboard parameters are already removed in DashboardStateSync during URL state sync, we remove them here preemptively.
+ *
+ * TODO: Implement permanent solution for embed URLs, possibly by ignoring non-dashboard parameters in DashboardStateSync.
+ */
+export function cleanEmbedUrlParams(searchParams: URLSearchParams) {
+  const cleanedParams = new URLSearchParams(searchParams);
+  [
+    "access_token",
+    "instance_id",
+    "kind",
+    "resource",
+    "runtime_host",
+    "type",
+  ].forEach((p) => cleanedParams.delete(p));
+  return cleanedParams;
+}