Skip to content

Commit e7ff945

Browse files
authored
Update comment about ::Array on CRuby, it's not fully thread-safe
1 parent c587821 commit e7ff945

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

lib/concurrent-ruby/concurrent/array.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ module Concurrent
2121
# @!macro internal_implementation_note
2222
ArrayImplementation = case
2323
when Concurrent.on_cruby?
24-
# Array is thread-safe in practice because CRuby runs
25-
# threads one at a time and does not do context
26-
# switching during the execution of C functions.
24+
# Array is not fully thread-safe on CRuby, see
25+
# https://github.com/ruby-concurrency/concurrent-ruby/issues/929
26+
# So we will need to add synchronization here
2727
::Array
2828

2929
when Concurrent.on_jruby?

0 commit comments

Comments
 (0)