Skip to content

Commit ec13658

Browse files
authored
remove apigateway for shameList (aws-controllers-k8s#577)
This pull request aims to remove API Gateway from the shameList, as the original reason for its inclusion is no longer valid. In the AWS SDK v1, there was an inconsistency in the naming convention between input and output shapes for API Gateway operations. Specifically, input shapes followed a pattern like `CreateDomainNameInput`, while output shapes were simply named `DomainName`. This inconsistency was one of the reasons API Gateway was placed on the shameList. However, with the release of AWS SDK v2, this naming inconsistency has been resolved. The new SDK now uses a standardized naming pattern for both input and output shapes across API Gateway operations. As a result, the special handling that was required is no longer necessary. For reference, we can compare the old naming convention in SDK v1 ([link](https://github.com/aws/aws-sdk-go/blob/main/service/apigateway/api.go#L5162)) with the new, consistent naming in SDK v2 ([link](https://github.com/aws/aws-sdk-go-v2/blob/main/service/apigateway/api_op_GetDomainName.go#L49)). By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 980cb1e commit ec13658

File tree

1 file changed

+0
-146
lines changed

1 file changed

+0
-146
lines changed

pkg/api/list_of_shame.go

Lines changed: 0 additions & 146 deletions
Original file line numberDiff line numberDiff line change
@@ -29,152 +29,6 @@ func (ts persistAPITypes) Output(serviceName, opName string) bool {
2929
// not generating unique input/output shapes is not desired, we will generate
3030
// unique input/output shapes for new operations.
3131
var shamelist = persistAPITypes{
32-
"APIGateway": {
33-
"CreateApiKey": {
34-
output: true,
35-
},
36-
"CreateAuthorizer": {
37-
output: true,
38-
},
39-
"CreateBasePathMapping": {
40-
output: true,
41-
},
42-
"CreateDeployment": {
43-
output: true,
44-
},
45-
"CreateDocumentationPart": {
46-
output: true,
47-
},
48-
"CreateDocumentationVersion": {
49-
output: true,
50-
},
51-
"CreateDomainName": {
52-
output: true,
53-
},
54-
"CreateModel": {
55-
output: true,
56-
},
57-
"CreateUsagePlan": {
58-
output: true,
59-
},
60-
"CreateUsagePlanKey": {
61-
output: true,
62-
},
63-
"GenerateClientCertificate": {
64-
output: true,
65-
},
66-
"GetAccount": {
67-
output: true,
68-
},
69-
"GetApiKey": {
70-
output: true,
71-
},
72-
"GetAuthorizer": {
73-
output: true,
74-
},
75-
"GetBasePathMapping": {
76-
output: true,
77-
},
78-
"GetClientCertificate": {
79-
output: true,
80-
},
81-
"GetDeployment": {
82-
output: true,
83-
},
84-
"GetDocumentationPart": {
85-
output: true,
86-
},
87-
"GetDocumentationVersion": {
88-
output: true,
89-
},
90-
"GetDomainName": {
91-
output: true,
92-
},
93-
"GetIntegrationResponse": {
94-
output: true,
95-
},
96-
"GetMethod": {
97-
output: true,
98-
},
99-
"GetMethodResponse": {
100-
output: true,
101-
},
102-
"GetModel": {
103-
output: true,
104-
},
105-
"GetSdkType": {
106-
output: true,
107-
},
108-
"GetUsage": {
109-
output: true,
110-
},
111-
"GetUsagePlan": {
112-
output: true,
113-
},
114-
"GetUsagePlanKey": {
115-
output: true,
116-
},
117-
"ImportRestApi": {
118-
output: true,
119-
},
120-
"PutIntegrationResponse": {
121-
output: true,
122-
},
123-
"PutMethod": {
124-
output: true,
125-
},
126-
"PutMethodResponse": {
127-
output: true,
128-
},
129-
"PutRestApi": {
130-
output: true,
131-
},
132-
"UpdateAccount": {
133-
output: true,
134-
},
135-
"UpdateApiKey": {
136-
output: true,
137-
},
138-
"UpdateAuthorizer": {
139-
output: true,
140-
},
141-
"UpdateBasePathMapping": {
142-
output: true,
143-
},
144-
"UpdateClientCertificate": {
145-
output: true,
146-
},
147-
"UpdateDeployment": {
148-
output: true,
149-
},
150-
"UpdateDocumentationPart": {
151-
output: true,
152-
},
153-
"UpdateDocumentationVersion": {
154-
output: true,
155-
},
156-
"UpdateDomainName": {
157-
output: true,
158-
},
159-
"UpdateIntegrationResponse": {
160-
output: true,
161-
},
162-
"UpdateMethod": {
163-
output: true,
164-
},
165-
"UpdateMethodResponse": {
166-
output: true,
167-
},
168-
"UpdateModel": {
169-
output: true,
170-
},
171-
"UpdateUsage": {
172-
output: true,
173-
},
174-
"UpdateUsagePlan": {
175-
output: true,
176-
},
177-
},
17832
"AutoScaling": {
17933
"ResumeProcesses": {
18034
input: true,

0 commit comments

Comments
 (0)