Skip to content

SPI TransferInPlace operation is unsound. #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reitermarkus opened this issue Jun 12, 2025 · 0 comments
Open

SPI TransferInPlace operation is unsound. #120

reitermarkus opened this issue Jun 12, 2025 · 0 comments

Comments

@reitermarkus
Copy link
Member

The implementation for the TransferInPlace operation violates the aliasing rule by creating an immutable reference from a mutable one, but keeping both.

SpiOperation::TransferInPlace(buf) => {
let tx = unsafe {
let p = buf.as_ptr();
std::slice::from_raw_parts(p, buf.len())
};
transfers.push(SpidevTransfer::read_write(tx, buf));
}

There needs to be a corresponding method for SpidevTransfer, e.g. read_write_in_place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant