Skip to content

Don't set CMAKE_SYSTEM_NAME=SunOS (and probably others) #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gco opened this issue Apr 27, 2022 · 1 comment · Fixed by #158
Closed

Don't set CMAKE_SYSTEM_NAME=SunOS (and probably others) #151

gco opened this issue Apr 27, 2022 · 1 comment · Fixed by #158

Comments

@gco
Copy link

gco commented Apr 27, 2022 •
edited
Loading

This has been seen before, notably #138, but setting CMAKE_SYSTEM_NAME causes cmake to be in a cross-compiling configuration even when it's building native. This causes rust-lang/rust#96054. Only set CMAKE_SYSTEM_NAME when explicitly cross-compiling?
@gco
Copy link
Author

gco commented May 4, 2022

That was introduced in 316dca5

@messense messense mentioned this issue Jul 26, 2022
Merged
@thomcc thomcc closed this as completed in cfe11fc Oct 28, 2022
@vigneshs-12 vigneshs-12 mentioned this issue Jul 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve cross compiling support
1 participant
@gco