use the sysv64 implementation for x86_64 is_like_darwin targets

folkertdev · folkertdev · commit fd769154d1b2 · 2025-05-28T00:45:10.000+02:00
diff --git a/compiler/rustc_codegen_llvm/src/va_arg.rs b/compiler/rustc_codegen_llvm/src/va_arg.rs
@@ -742,7 +742,8 @@ pub(super) fn emit_va_arg<'ll, 'tcx>(
                 AllowHigherAlign::No,
             )
         }
-        "x86_64" if !target.is_like_darwin => emit_x86_64_sysv64_va_arg(bx, addr, target_ty),
+        // This includes `target.is_like_darwin`, which on x86_64 targets is like sysv64.
+        "x86_64" => emit_x86_64_sysv64_va_arg(bx, addr, target_ty),
         "xtensa" => emit_xtensa_va_arg(bx, addr, target_ty),
         // For all other architecture/OS combinations fall back to using
         // the LLVM va_arg instruction.

Original file line number	Diff line number	Diff line change
`@@ -742,7 +742,8 @@ pub(super) fn emit_va_arg<'ll, 'tcx>(`
`742`	`742`	`AllowHigherAlign::No,`
`743`	`743`	`)`
`744`	`744`	`}`
`745`		`- "x86_64" if !target.is_like_darwin => emit_x86_64_sysv64_va_arg(bx, addr, target_ty),`
	`745`	+ // This includes `target.is_like_darwin`, which on x86_64 targets is like sysv64.
	`746`	`+ "x86_64" => emit_x86_64_sysv64_va_arg(bx, addr, target_ty),`
`746`	`747`	`"xtensa" => emit_xtensa_va_arg(bx, addr, target_ty),`
`747`	`748`	`// For all other architecture/OS combinations fall back to using`
`748`	`749`	`// the LLVM va_arg instruction.`