More more clippy

Author: termoshtt

src/layout.rs

@@ -46,6 +46,10 @@ impl MatrixLayout {
         }
     }
 
+    pub fn is_empty(&self) -> bool {
+        self.len() == 0
+    }
+
     pub fn lapacke_layout(&self) -> lapacke::Layout {
         match *self {
             MatrixLayout::C(_) => lapacke::Layout::RowMajor,

src/lib.rs

@@ -41,7 +41,8 @@
 #![allow(
     clippy::module_inception,
     clippy::many_single_char_names,
-    clippy::type_complexity
+    clippy::type_complexity,
+    clippy::ptr_arg
 )]
 
 #[macro_use]

src/lobpcg/lobpcg.rs

@@ -46,12 +46,11 @@ fn sorted_eig<S: Data<Elem = A>, A: Scalar + Lapack>(
 
     Ok(match order {
         Order::Largest => (
-            vals.slice_move(s![n-size..; -1])
-                .mapv(|x| Scalar::from_real(x)),
+            vals.slice_move(s![n-size..; -1]).mapv(Scalar::from_real),
             vecs.slice_move(s![.., n-size..; -1]),
         ),
         Order::Smallest => (
-            vals.slice_move(s![..size]).mapv(|x| Scalar::from_real(x)),
+            vals.slice_move(s![..size]).mapv(Scalar::from_real),
             vecs.slice_move(s![.., ..size]),
         ),
     })
@@ -62,7 +61,7 @@ fn ndarray_mask<A: Scalar>(matrix: ArrayView2<A>, mask: &[bool]) -> Array2<A> {
     assert_eq!(mask.len(), matrix.ncols());
 
     let indices = (0..mask.len())
-        .zip(mask.into_iter())
+        .zip(mask.iter())
         .filter(|(_, b)| **b)
         .map(|(a, _)| a)
         .collect::<Vec<usize>>();
@@ -435,7 +434,7 @@ pub fn lobpcg<
 
     // retrieve best result and convert norm into `A`
     let (vals, vecs, rnorm) = best_result.unwrap();
-    let rnorm = rnorm.into_iter().map(|x| Scalar::from_real(x)).collect();
+    let rnorm = rnorm.into_iter().map(Scalar::from_real).collect();
 
     match final_norm {
         Ok(_) => LobpcgResult::Ok(vals, vecs, rnorm),

src/lobpcg/svd.rs

@@ -160,7 +160,7 @@ impl<A: Float + Scalar + ScalarOperand + Lapack + PartialOrd + Default> Truncate
         match res {
             LobpcgResult::Ok(vals, vecs, _) | LobpcgResult::Err(vals, vecs, _, _) => {
                 Ok(TruncatedSvdResult {
-                    problem: self.problem.clone(),
+                    problem: self.problem,
                     eigvals: vals,
                     eigvecs: vecs,
                     ngm: n > m,

src/norm.rs

@@ -65,7 +65,7 @@ where
     for mut v in m.axis_iter_mut(Axis(axis as usize)) {
         let n = v.norm();
         ms.push(n);
-        v.map_inplace(|x| *x = *x / A::from_real(n))
+        v.map_inplace(|x| *x /= A::from_real(n))
     }
     (m, ms)
 }

src/solveh.rs

@@ -323,8 +323,8 @@ where
             // 1x1 block at k, must be real.
             let elem = unsafe { a.uget((k, k)) }.re();
             debug_assert_eq!(elem.im(), Zero::zero());
-            sign = sign * elem.signum();
-            ln_det = ln_det + elem.abs().ln();
+            sign *= elem.signum();
+            ln_det += elem.abs().ln();
         } else {
             // 2x2 block at k..k+2.
 
@@ -344,8 +344,8 @@ where
 
             // Determinant of 2x2 block.
             let block_det = upper_diag * lower_diag - off_diag.square();
-            sign = sign * block_det.signum();
-            ln_det = ln_det + block_det.abs().ln();
+            sign *= block_det.signum();
+            ln_det += block_det.abs().ln();
 
             // Skip the k+1 ipiv value.
             ipiv_enum.next();