Skip to content

Commit a3831c9

Browse files
choose a crypto_provider for rustls_cert_gen (#206)
From the release 0.12 of rcgen #202 , we must now choose `ring` or `aws_lc_rc` as a feature. Because `rustls_cert_gen` has `default-features = false`, its build is currently broken. This PR activate `aws_lc_rc` feature, because soon it will get RSA key generation support aws/aws-lc-rs#296 , so it will provide more options. But we could also change it to default to whatever `rcgen` default or use `ring` as default depending on your preferences.
1 parent 6637060 commit a3831c9

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

.github/workflows/ci.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,21 @@ jobs:
177177
- name: Run the tests with aws_lc_rs backend enabled
178178
run: cargo test --verbose --no-default-features --features aws_lc_rs,pem --all-targets
179179

180+
# Build rustls-cert-gen as a standalone package, see this PR for why it's needed:
181+
# https://github.com/rustls/rcgen/pull/206#pullrequestreview-1816197358
182+
build-rustls-cert-gen-standalone:
183+
name: Build rustls-cert-gen as a standalone package
184+
runs-on: ubuntu-latest
185+
steps:
186+
- name: Checkout sources
187+
uses: actions/checkout@v4
188+
with:
189+
persist-credentials: false
190+
- name: Install rust toolchain
191+
uses: dtolnay/rust-toolchain@stable
192+
- name: Run the tests
193+
run: cargo test --package rustls-cert-gen
194+
180195
coverage:
181196
name: Measure coverage
182197
runs-on: ubuntu-latest

rustls-cert-gen/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ edition.workspace = true
77
keywords.workspace = true
88

99
[dependencies]
10-
rcgen = { path = "../rcgen", default-features = false, features = ["pem"] }
10+
rcgen = { path = "../rcgen", default-features = false, features = ["pem", "ring"] }
1111
bpaf = { version = "0.9.5", features = ["derive"] }
1212
pem = { workspace = true }
1313
ring = { workspace = true }

0 commit comments

Comments
 (0)