Skip to content

fix: always render apex test reports W-17758238 #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

cristiand391
Copy link
Member

What does this PR do?

Updates test formatters to always print apex test reports unless the caller doesn't want to.
This fixes a regression introduced in this PR where commands were missing the Test Failures report on CI runs of commands like project deploy report.

What issues does this PR fix or reference?

@W-17758238@

@mdonnalley
Copy link
Collaborator

QA

🟢 failed tests are shown in sf project deploy report

❯ CI=true sf project deploy report -i 0AfO200000LqE1BKAV
 ›   Warning: @salesforce/plugin-deploy-retrieve is a linked ESM module and cannot be auto-transpiled. Existing compiled source will be used instead.
0AfO200000LqE1BKAV... Failed

Deploy Info
 Key                       Value
----------------------------------------------------
 checkOnly                 false
 completedDate             2025-02-10T18:54:59.000Z
 createdBy                 005O200000CymHN
 createdByName             User User
 createdDate               2025-02-10T18:54:43.000Z
 done                      true
 id                        0AfO200000LqE1BKAV
 ignoreWarnings            false
 lastModifiedDate          2025-02-10T18:54:59.000Z
 numberComponentErrors     0
 numberComponentsDeployed  93
 numberComponentsTotal     93
 numberTestErrors          1
 numberTestsCompleted      10
 numberTestsTotal          11
 rollbackOnError           true
 runTestsEnabled           true
 startDate                 2025-02-10T18:54:44.000Z
 status                    Failed
 success                   false


Deploy Options
 Key               Value
------------------------------------------------------------------------------
 dry-run           false
 ignore-conflicts  false
 ignore-errors     false
 ignore-warnings   false
 target-org        [email protected]
 test-level        RunLocalTests
 api               REST
 manifest          /Users/mdonnalley/.sf/manifestCache/0AfO200000LqE1BKAV.xml
 wait              33 minutes
 isMdapi           false
 status            Failed
 job-id            0AfO200000LqE1BKAV


Test Failures [1]
• FileUtilitiesTest.createFileSucceedsWhenCorrectInput
  message: System.AssertException: Assertion Failed: Nullable object asserted with non null value
  stacktrace:
    External entry point
    Class.FileUtilitiesTest.createFileSucceedsWhenCorrectInput: line 21, column 1


Test Results Summary
Passing: 10
Failing: 1
Total: 11
Time: 3565

@mdonnalley mdonnalley merged commit 46cfcd3 into main Feb 10, 2025
40 of 45 checks passed
@mdonnalley mdonnalley deleted the cd/ci-failure-report branch February 10, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants