Skip to content

Allow shadowing service fields when extending commands #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imagejan opened this issue Nov 24, 2020 · 1 comment · Fixed by #422
Closed

Allow shadowing service fields when extending commands #408

imagejan opened this issue Nov 24, 2020 · 1 comment · Fixed by #422

Comments

@imagejan
Copy link
Member

See fiji/FilamentDetector#24 (comment).

@imagejan
Copy link
Member Author

imagejan commented May 3, 2021

Here's probably where we could change this, by excluding Service types from the check:

final String name = f.getName();
if (inputMap.containsKey(name) || outputMap.containsKey(name)) {
// NB: Shadowed parameters are bad because they are ambiguous.
final String error = "Invalid duplicate parameter: " + f;
problems.add(new ValidityProblem(error));
valid = false;
}

@imagejan imagejan changed the title Allow private service fields Allow shadowing service fields when extending commands May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant