Skip to content

Commit f1ee141

Browse files
henryiiijcfr
andauthored
Apply suggestions from code review
Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
1 parent c5422eb commit f1ee141

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

README.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,8 @@ The following platforms are supported with binary wheels:
6969
| macOS 11+ | Apple Silicon |
7070
+---------------+--------------------------+
7171

72-
The last version to provide ``manylinux1`` wheels was ``3.22.x``. The last version to provide Python 2 to Python 3.6 support was ``3.28.x``.
72+
The last version to provide ``manylinux1`` wheels was ``3.22.x``.
73+
The last version to provide Python 2 to Python 3.6 support was ``3.28.x``.
7374

7475
Maintainers
7576
-----------

noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,6 @@ def tag_release(session: nox.Session) -> None:
168168

169169
session.log("Run the following commands to make a release:")
170170
txt = Path("pyproject.toml").read_text()
171-
current_version = next(iter(re.finditer(r'version = "([\d\.]+)"', txt))).group(1)
171+
current_version = next(iter(re.finditer(r'^version = "([\d\.]+)"$', txt, flags=re.MULTILINE))).group(1)
172172
print(f"git tag --sign -m 'cmake-python-distributions {current_version}' {current_version} main")
173173
print(f"git push origin {current_version}")

scripts/update_cmake_version.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,10 +183,10 @@ def update_tests(version):
183183

184184

185185
def update_pyproject_toml(version):
186-
pattern = re.compile(r'version = "[\w\.]+"')
186+
pattern = re.compile(r'^version = "[\w\.]+"$')
187187
replacement = 'version = "%s"' % version
188188
_update_file(
189-
os.path.join(ROOT_DIR, "tests/test_cmake.py"), pattern, replacement
189+
os.path.join(ROOT_DIR, "pyproject.toml"), pattern, replacement
190190
)
191191

192192

0 commit comments

Comments
 (0)