Skip to content

Commit 0caff7c

Browse files
committed
Fix helm chart test for EOL NodeJS 18.
The NodeJS 18 is not present in Helm Charts at all. It reached EOL in Apr 2025 Signed-off-by: Petr "Stone" Hracek <[email protected]>
1 parent 6b93be1 commit 0caff7c

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

test/test_shared_helm_nodejs_imagestreams.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -29,23 +29,23 @@ def teardown_method(self):
2929
self.hc_api.delete_project()
3030

3131
@pytest.mark.parametrize(
32-
"version,registry",
32+
"version,registry,expected",
3333
[
34-
("22-ubi10", "registry.redhat.io/ubi10/nodejs-22:latest"),
35-
("22-ubi10-minimal", "registry.redhat.io/ubi10/nodejs-22-minimal:latest"),
36-
("22-ubi9", "registry.redhat.io/ubi9/nodejs-22:latest"),
37-
("22-ubi9-minimal", "registry.redhat.io/ubi9/nodejs-22-minimal:latest"),
38-
("20-ubi9", "registry.redhat.io/ubi9/nodejs-20:latest"),
39-
("20-ubi9-minimal", "registry.redhat.io/ubi9/nodejs-20-minimal:latest"),
40-
("20-ubi8", "registry.redhat.io/ubi8/nodejs-20:latest"),
41-
("20-ubi8-minimal", "registry.redhat.io/ubi8/nodejs-20-minimal:latest"),
42-
("18-ubi9", "registry.redhat.io/ubi9/nodejs-18:latest"),
43-
("18-ubi9-minimal", "registry.redhat.io/ubi9/nodejs-18-minimal:latest"),
44-
("18-ubi8", "registry.redhat.io/ubi8/nodejs-18:latest"),
45-
("18-ubi8-minimal", "registry.redhat.io/ubi8/nodejs-18-minimal:latest"),
34+
("22-ubi10", "registry.redhat.io/ubi10/nodejs-22:latest", True),
35+
("22-ubi10-minimal", "registry.redhat.io/ubi10/nodejs-22-minimal:latest", True),
36+
("22-ubi9", "registry.redhat.io/ubi9/nodejs-22:latest", True),
37+
("22-ubi9-minimal", "registry.redhat.io/ubi9/nodejs-22-minimal:latest", True),
38+
("20-ubi9", "registry.redhat.io/ubi9/nodejs-20:latest", True),
39+
("20-ubi9-minimal", "registry.redhat.io/ubi9/nodejs-20-minimal:latest", True),
40+
("20-ubi8", "registry.redhat.io/ubi8/nodejs-20:latest", True),
41+
("20-ubi8-minimal", "registry.redhat.io/ubi8/nodejs-20-minimal:latest", True),
42+
("18-ubi9", "registry.redhat.io/ubi9/nodejs-18:latest", False),
43+
("18-ubi9-minimal", "registry.redhat.io/ubi9/nodejs-18-minimal:latest", False),
44+
("18-ubi8", "registry.redhat.io/ubi8/nodejs-18:latest", False),
45+
("18-ubi8-minimal", "registry.redhat.io/ubi8/nodejs-18-minimal:latest", False),
4646
],
4747
)
48-
def test_package_imagestream(self, version, registry):
48+
def test_package_imagestream(self, version, registry, expected):
4949
assert self.hc_api.helm_package()
5050
assert self.hc_api.helm_installation()
51-
assert self.hc_api.check_imagestreams(version=version, registry=registry)
51+
assert self.hc_api.check_imagestreams(version=version, registry=registry) == expected

0 commit comments

Comments
 (0)