Skip to content

Commit 2dad72b

Browse files
authored
Merge pull request #227 from KManolov3/fix/uepr-222-debug-modal-strings-in-transifex
fix: rename file with debug modal messages to .js
2 parents d683098 + 56ecba2 commit 2dad72b

File tree

4 files changed

+22
-16
lines changed

4 files changed

+22
-16
lines changed

packages/scratch-gui/src/components/debug-modal/sections/messages.ts renamed to packages/scratch-gui/src/components/debug-modal/sections/messages.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
import {defineMessages} from 'react-intl';
22

3+
// TODO: These are not detected by the `i18n:src` script if the file is with `.ts` extension.
4+
// This issue might be affecting other .ts files as well.
5+
// https://scratchfoundation.atlassian.net/browse/UEPR-221
36
export const messages = defineMessages({
47
readAloudTitle: {
58
id: 'gui.debugModal.readAloud.title',

packages/scratch-gui/src/components/debug-modal/sections/sections.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react';
22
import {FormattedMessage} from 'react-intl';
3-
import {messages} from './messages.ts';
3+
import {messages} from './messages.js';
44

55
import addSoundCheckpoints from '../icons/icon--add-sound-checkpoints.svg';
66
import askForHelp from '../icons/icon--ask-for-help.svg';
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
import {defineMessages} from 'react-intl';
2+
3+
const messages = defineMessages({
4+
meow: {
5+
defaultMessage: 'Meow',
6+
description: 'Name for the meow sound',
7+
id: 'gui.defaultProject.meow'
8+
},
9+
variable: {
10+
defaultMessage: 'my variable',
11+
description: 'Name for the default variable',
12+
id: 'gui.defaultProject.variable'
13+
}
14+
});
15+
16+
export default messages;

packages/scratch-gui/src/lib/default-project/project-data.ts

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,8 @@
1-
import {defineMessages} from 'react-intl';
1+
import projectDataMessages from './messages';
22
import sharedMessages from '../shared-messages';
33
import {MessageObject, TranslatorFunction} from '../../gui-config';
44

5-
let messages = defineMessages({
6-
meow: {
7-
defaultMessage: 'Meow',
8-
description: 'Name for the meow sound',
9-
id: 'gui.defaultProject.meow'
10-
},
11-
variable: {
12-
defaultMessage: 'my variable',
13-
description: 'Name for the default variable',
14-
id: 'gui.defaultProject.variable'
15-
}
16-
});
17-
18-
messages = {...messages, ...sharedMessages};
5+
const messages = {...projectDataMessages, ...sharedMessages};
196

207
// use the default message if a translation function is not passed
218
const defaultTranslator = (msgObj: MessageObject) => msgObj.defaultMessage;

0 commit comments

Comments
 (0)