Introduce ActiveResource::WhereClause

Closes [rails#408][]

Introduce a simple chainable `WhereClause` class inspired by [Active
Record][].

All methods (including those that integrate with [Enumerable][]) are
delegated to `WhereClause#all`, which itself delegates to `Base.find`.

By merging parameters through `.where`-chaining, this commit supports
deferred fetching:

```ruby
people = Person.where(id: 2).where(name: "david")
  # => GET /people.json?id=2&name=david

people = Person.where(id: 2).all(params: { name: "david" })
  # => GET /people.json?id=2&name=david

people = Person.all(from: "/records.json").where(id: 2)
  # => GET /records.json?id=2
```

[rails#408]: rails#408
[Active Record]: https://github.com/rails/rails/blob/main/activerecord/lib/active_record/relation/where_clause.rb
[Enumerable]: https://ruby-doc.org/3.4.1/Enumerable.html

Author: seanpdoyle

lib/active_resource.rb

@@ -46,6 +46,7 @@ module ActiveResource
   autoload :InheritingHash
   autoload :Validations
   autoload :Collection
+  autoload :WhereClause
 
   if ActiveSupport::VERSION::STRING >= "7.1"
     def self.deprecator

lib/active_resource/base.rb

@@ -1036,13 +1036,13 @@ def last(*args)
 
       # This is an alias for find(:all). You can pass in all the same
       # arguments to this method as you can to <tt>find(:all)</tt>
-      def all(*args)
-        find(:all, *args)
+      def all(options = {})
+        WhereClause.new(self, options)
       end
 
       def where(clauses = {})
         raise ArgumentError, "expected a clauses Hash, got #{clauses.inspect}" unless clauses.is_a? Hash
-        find(:all, params: clauses)
+        all(params: clauses)
       end
 
 

lib/active_resource/where_clause.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module ActiveResource
+  class WhereClause
+    delegate :find, to: :@resource_class
+    delegate_missing_to :to_a
+
+    def initialize(resource_class, options)
+      @resource_class = resource_class
+      @options = options
+    end
+
+    def all(options = {})
+      find(:all, @options.deep_merge(options))
+    end
+
+    def where(clauses = {})
+      WhereClause.new(@resource_class, @options.deep_merge(params: clauses))
+    end
+
+    def to_a
+      find(:all, @options)
+    end
+  end
+end

test/cases/collection_test.rb

@@ -118,6 +118,6 @@ def test_first_or_initialize
   def test_where
     posts = PaginatedPost.where(page: 2)
     next_posts = posts.where(title: "Awesome")
-    assert_kind_of PaginatedCollection, next_posts
+    assert_kind_of PaginatedCollection, next_posts.all
   end
 end

test/cases/finder_test.rb

@@ -63,6 +63,36 @@ def test_where_with_clauses
     assert_kind_of StreetAddress, addresses.first
   end
 
+  def test_where_with_multiple_where_clauses
+    ActiveResource::HttpMock.respond_to.get "/people.json?id=2&name=david", {}, @people_david
+
+    people = Person.where(id: 2).where(name: "david")
+    assert_equal 1, people.size
+    assert_kind_of Person, people.first
+    assert_equal 2, people.first.id
+    assert_equal "David", people.first.name
+  end
+
+  def test_where_chained_from_all
+    ActiveResource::HttpMock.respond_to.get "/records.json?id=2", {}, @people_david
+
+    people = Person.all(from: "/records.json").where(id: 2)
+    assert_equal 1, people.size
+    assert_kind_of Person, people.first
+    assert_equal 2, people.first.id
+    assert_equal "David", people.first.name
+  end
+
+  def test_where_with_multiple_where_clauses_triggered_by_all
+    ActiveResource::HttpMock.respond_to.get "/records.json?id=2&name=david", {}, @people_david
+
+    people = Person.where(id: 2).all(from: "/records.json", params: { name: "david" })
+    assert_equal 1, people.size
+    assert_kind_of Person, people.first
+    assert_equal 2, people.first.id
+    assert_equal "David", people.first.name
+  end
+
   def test_where_with_clause_in
     ActiveResource::HttpMock.respond_to { |m| m.get "/people.json?id%5B%5D=2", {}, @people_david }
     people = Person.where(id: [2])