FreeBSD: add missing seqc write begin/end around zfs_acl_chown_setattr

mjguzik · RageLtMan · commit be3894a58002 · 2021-05-31T01:05:20.000-04:00
It happens to trip over an assert but does not matter for correctness at this time. Done for future proofing. Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com> Closes openzfs#11884
diff --git a/module/os/freebsd/zfs/zfs_vnops_os.c b/module/os/freebsd/zfs/zfs_vnops_os.c
@@ -2795,7 +2795,9 @@ zfs_setattr(znode_t *zp, vattr_t *vap, int flags, cred_t *cr)
 		err = zfs_acl_chown_setattr(zp);
 		ASSERT(err == 0);
 		if (attrzp) {
+			vn_seqc_write_begin(ZTOV(attrzp));
 			err = zfs_acl_chown_setattr(attrzp);
+			vn_seqc_write_end(ZTOV(attrzp));
 			ASSERT(err == 0);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -2795,7 +2795,9 @@ zfs_setattr(znode_t zp, vattr_t vap, int flags, cred_t *cr)`
`2795`	`2795`	`err = zfs_acl_chown_setattr(zp);`
`2796`	`2796`	`ASSERT(err == 0);`
`2797`	`2797`	`if (attrzp) {`
	`2798`	`+ vn_seqc_write_begin(ZTOV(attrzp));`
`2798`	`2799`	`err = zfs_acl_chown_setattr(attrzp);`
	`2800`	`+ vn_seqc_write_end(ZTOV(attrzp));`
`2799`	`2801`	`ASSERT(err == 0);`
`2800`	`2802`	`}`
`2801`	`2803`	`}`