-
Notifications
You must be signed in to change notification settings - Fork 159
Semantic inconsistencies between listen
and emit
tasks
#917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
listen
and emit
taskslisten
and emit
tasks
@ricardozanini @matthias-pichler-warrify @fjtirado What do you guys think? Should I proceed with it? |
@fjtirado |
But yes, if you want to keep with on listen, it makes sense to add it to emit in order to make it symmetric. |
Ok, correcting myself (I did not see the format point) yes, lets add with both for emit and listen.
|
(Just a side note, there is a dead link in emit in the column Type, on the word "event" --> https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#event) |
@fjtirado tbh it's mostly for aestetics and semantics that I thought of adding the |
@JBBianchi good catch! Would you be so kind to open a PR to fix it? |
I think this can be tackled at the same time than the current topic. That being said, I can open a PR once we agree on the direction we want to take. |
What seems off:
The
listen
task allows for user to configure events to listen to in the following way:Whereas the
emit
task does not define thewith
keyword:What you expected to be:
The
emit
task to define awith
keyword, use to define event properties:This would allow for potential future properties such as
format
, and would make it more fluent, ubiquitous and consistent.The text was updated successfully, but these errors were encountered: