Skip to content

Commit 3e7d1ed

Browse files
committed
Removing an inappropriate class used to wrap inline radio form controls.
Adding class to control left alignment at mobile. Fixes openshift#1240 Fixes openshift#1234
1 parent 3f779bc commit 3e7d1ed

File tree

5 files changed

+20
-8
lines changed

5 files changed

+20
-8
lines changed

app/styles/_forms.less

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,3 +86,16 @@
8686
// the sections just above.
8787
margin-top: @line-height-computed;
8888
}
89+
90+
// Wrap for inline radio and/or checkbox groups that are displayed inline.
91+
.radio-checkbox-group-inline {
92+
display: block;
93+
@media (max-width: @screen-xs-max) {
94+
// switch default bootstrap margin to right side to enable left alignment of inputs at mobile
95+
.radio-inline,
96+
.checkbox-inline {
97+
margin-left: 0;
98+
margin-right: 10px;
99+
}
100+
}
101+
}

app/views/directives/edit-lifecycle-hook.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
<div class="form-group">
1212
<label for="actionType" class="required">Lifecycle Action</label><br/>
13-
<div class="radio">
13+
<div class="radio-checkbox-group-inline">
1414
<label class="radio-inline">
1515
<input type="radio"
1616
name="{{type}}-action-newpod"

app/views/directives/osc-persistent-volume-claim.html

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -90,23 +90,19 @@
9090

9191
<div class="form-group" >
9292
<label class="required">Access Mode</label>
93-
<div class="radio">
94-
93+
<div class="radio-checkbox-group-inline">
9594
<label class="radio-inline">
9695
<input type="radio" name="accessModes" ng-model="claim.accessModes" value="ReadWriteOnce" aria-describedby="access-modes-help" ng-checked="true" >
9796
Single User (RWO)
9897
</label>
99-
10098
<label class="radio-inline">
10199
<input type="radio" id="accessModes" name="accessModes" ng-model="claim.accessModes" value="ReadWriteMany" aria-describedby="access-modes-help" >
102100
Shared Access (RWX)
103101
</label>
104-
105102
<label class="radio-inline">
106103
<input type="radio" name="accessModes" ng-model="claim.accessModes" value="ReadOnlyMany" aria-describedby="access-modes-help">
107104
Read Only (ROX)
108105
</label>
109-
110106
</div>
111107
<div>
112108
<span id="access-modes-help" class="help-block">Permissions to the mounted volume.</span>

dist/scripts/templates.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6858,7 +6858,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
68586858
"<fieldset ng-disabled=\"view.isDisabled\">\n" +
68596859
"<div class=\"form-group\">\n" +
68606860
"<label for=\"actionType\" class=\"required\">Lifecycle Action</label><br/>\n" +
6861-
"<div class=\"radio\">\n" +
6861+
"<div class=\"radio-checkbox-group-inline\">\n" +
68626862
"<label class=\"radio-inline\">\n" +
68636863
"<input type=\"radio\" name=\"{{type}}-action-newpod\" ng-model=\"action.type\" value=\"execNewPod\" aria-describedby=\"action-help\">\n" +
68646864
"Run a specific command in a new pod\n" +
@@ -7996,7 +7996,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
79967996
"</div>\n" +
79977997
"<div class=\"form-group\">\n" +
79987998
"<label class=\"required\">Access Mode</label>\n" +
7999-
"<div class=\"radio\">\n" +
7999+
"<div class=\"radio-checkbox-group-inline\">\n" +
80008000
"<label class=\"radio-inline\">\n" +
80018001
"<input type=\"radio\" name=\"accessModes\" ng-model=\"claim.accessModes\" value=\"ReadWriteOnce\" aria-describedby=\"access-modes-help\" ng-checked=\"true\">\n" +
80028002
"Single User (RWO)\n" +

dist/styles/main.css

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3600,6 +3600,9 @@ to{transform:rotate(359deg)}
36003600
}
36013601
.osc-file-input textarea{font-family:Menlo,Monaco,Consolas,monospace;margin:5px 0}
36023602
.health-checks-form .pause-rollouts-checkbox,.set-limits-form .pause-rollouts-checkbox{margin-top:21px}
3603+
.radio-checkbox-group-inline{display:block}
3604+
@media (max-width:767px){.radio-checkbox-group-inline .checkbox-inline,.radio-checkbox-group-inline .radio-inline{margin-left:0;margin-right:10px}
3605+
}
36033606
.card-pf{box-shadow:0 3px 1px -2px rgba(0,0,0,.15),0 2px 2px 0 rgba(0,0,0,.1),0 1px 5px 0 rgba(0,0,0,.09)}
36043607
.card-pf .image-icon,.card-pf .template-icon{font-size:28px;line-height:1;margin-right:15px;opacity:.38}
36053608
.card-pf-badge{color:#999;font-size:11px;text-transform:uppercase}

0 commit comments

Comments
 (0)