Skip to content

Drop optional from common.PublicKey.raw_bytes #325

Open
@woodruffw

Description

@woodruffw

In practice, the PublicKey message is used in settings that require direct access to the raw_bytes, with the assumption that it isn't missing.

message PublicKey {
// DER-encoded public key, encoding method is specified by the
// key_details attribute.
optional bytes raw_bytes = 1;
// Key encoding and signature algorithm to use for this key.
PublicKeyDetails key_details = 2;
// Optional validity period for this key, *inclusive* of the endpoints.
optional TimeRange valid_for = 3;
}

We should be able to drop the optional qualifier here without causing any real breakage -- proto3 is still implicitly optional everywhere, so dropping optional will just refine the type hints.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions