schema used pass-by-value and move

Author: silverqx

include/orm/schema/blueprint.hpp

@@ -700,24 +700,24 @@ namespace Grammars
     }
 
     ColumnDefinitionReference<>
-    Blueprint::unsignedFloat(const QString &column, const std::optional<int> total,
-                             const std::optional<int> places)
+    Blueprint::unsignedFloat(const QString &column, std::optional<int> total,
+                             std::optional<int> places)
     {
-        return Float(column, total, places, true);
+        return Float(column, std::move(total), std::move(places), true);
     }
 
     ColumnDefinitionReference<>
-    Blueprint::unsignedDouble(const QString &column, const std::optional<int> total,
-                              const std::optional<int> places)
+    Blueprint::unsignedDouble(const QString &column, std::optional<int> total,
+                              std::optional<int> places)
     {
-        return Double(column, total, places, true);
+        return Double(column, std::move(total), std::move(places), true);
     }
 
     ColumnDefinitionReference<>
-    Blueprint::unsignedDecimal(const QString &column, const std::optional<int> total,
-                               const std::optional<int> places)
+    Blueprint::unsignedDecimal(const QString &column, std::optional<int> total,
+                               std::optional<int> places)
     {
-        return decimal(column, total, places, true);
+        return decimal(column, std::move(total), std::move(places), true);
     }
 
     void Blueprint::datetimes(std::optional<int> precision)

src/orm/schema/blueprint.cpp

@@ -296,27 +296,30 @@ ColumnDefinitionReference<> Blueprint::longText(const QString &column)
 
 // TODO schema, fix and unify real/double/float types with latest standard and remove deprecated APIs, what I have understood from the MySQL and PostgreSQL docs it should be like this; I should have real and double (double precision) types without any total, places or precision params and then I should have float type that should have precision param, currently this total and places params are depreceted as described in https://dev.mysql.com/doc/refman/8.0/en/floating-point-types.html and will be removed in future, also add this column types to tests and to the playground also check numeric/decimal type, its different animal silverqx
 ColumnDefinitionReference<>
-Blueprint::Float(const QString &column, const std::optional<int> total,
-                 const std::optional<int> places, const bool isUnsigned)
+Blueprint::Float(const QString &column, std::optional<int> total,
+                 std::optional<int> places, const bool isUnsigned)
 {
-    return addColumn(ColumnType::Float, column, {.places = places, .total = total,
-                                                 .isUnsigned = isUnsigned});
+    return addColumn(ColumnType::Float, column,
+                     {.places = std::move(places), .total = std::move(total),
+                      .isUnsigned = isUnsigned});
 }
 
 ColumnDefinitionReference<>
-Blueprint::Double(const QString &column, const std::optional<int> total,
-                  const std::optional<int> places, const bool isUnsigned)
+Blueprint::Double(const QString &column, std::optional<int> total,
+                  std::optional<int> places, const bool isUnsigned)
 {
-    return addColumn(ColumnType::Double, column, {.places = places, .total = total,
-                                                  .isUnsigned = isUnsigned});
+    return addColumn(ColumnType::Double, column,
+                     {.places = std::move(places), .total = std::move(total),
+                      .isUnsigned = isUnsigned});
 }
 
 ColumnDefinitionReference<>
-Blueprint::decimal(const QString &column, const std::optional<int> total,
-                   const std::optional<int> places, const bool isUnsigned)
+Blueprint::decimal(const QString &column, std::optional<int> total,
+                   std::optional<int> places, const bool isUnsigned)
 {
-    return addColumn(ColumnType::Decimal, column, {.places = places, .total = total,
-                                                   .isUnsigned = isUnsigned});
+    return addColumn(ColumnType::Decimal, column,
+                     {.places = std::move(places), .total = std::move(total),
+                      .isUnsigned = isUnsigned});
 }
 
 ColumnDefinitionReference<> Blueprint::boolean(const QString &column)
@@ -445,9 +448,9 @@ ColumnDefinitionReference<> Blueprint::geometry(const QString &column)
 }
 
 ColumnDefinitionReference<>
-Blueprint::point(const QString &column, const std::optional<quint32> srid)
+Blueprint::point(const QString &column, std::optional<quint32> srid)
 {
-    return addColumn(ColumnType::Point, column, {.srid = srid});
+    return addColumn(ColumnType::Point, column, {.srid = std::move(srid)});
 }
 
 ColumnDefinitionReference<> Blueprint::lineString(const QString &column)