Convert git commit summary to valid UTF8. (go-gitea#28356)

darrinsmart · Darrin Smart · silverwind · commit d0d82d6974a9 · 2024-02-20T19:32:06.000+01:00
The summary string ends up in the database, and (at least) MySQL & PostgreSQL require valid UTF8 strings. Fixes go-gitea#28178 Co-authored-by: Darrin Smart <darrin@filmlight.ltd.uk>
diff --git a/modules/git/commit.go b/modules/git/commit.go
@@ -43,8 +43,9 @@ func (c *Commit) Message() string {
 }
 
 // Summary returns first line of commit message.
+// The string is forced to be valid UTF8
 func (c *Commit) Summary() string {
-	return strings.Split(strings.TrimSpace(c.CommitMessage), "\n")[0]
+	return strings.ToValidUTF8(strings.Split(strings.TrimSpace(c.CommitMessage), "\n")[0], "?")
 }
 
 // ParentID returns oid of n-th parent (0-based index).

Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,9 @@ func (c *Commit) Message() string {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`// Summary returns first line of commit message.`
	`46`	`+// The string is forced to be valid UTF8`
`46`	`47`	`func (c *Commit) Summary() string {`
`47`		`- return strings.Split(strings.TrimSpace(c.CommitMessage), "\n")[0]`
	`48`	`+ return strings.ToValidUTF8(strings.Split(strings.TrimSpace(c.CommitMessage), "\n")[0], "?")`
`48`	`49`	`}`
`49`	`50`
`50`	`51`	`// ParentID returns oid of n-th parent (0-based index).`