Skip to content

Commit 052a2d0

Browse files
committed
Add requirements to pull request template
1 parent 56ca580 commit 052a2d0

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,16 @@
1313
#### Solution - optional
1414
> When contributing code (and not just fixing typos, documentation and configuration), please describe why/how your solution works. This helps reviewers spot any mistakes in the implementation.
1515
>
16-
> Example:
16+
> Example:
1717
> "This solution works by adding a `paintBlue()` method"
1818
> Then your reviewer might spot a mistake in the implementation, if `paintBlue()` uses the colour red.
1919
2020
#### How to verify - mandatory
21-
1. Check out this branch (see github instructions below)
21+
1. Check out this branch
2222
2. `npm install`
2323
3. <your-steps-here>
24+
25+
#### Checklist for author
26+
27+
- [ ] `npm run lint` passes
28+
- [ ] References to standard library functions are [cached](https://github.com/sinonjs/sinon/pull/1523).

0 commit comments

Comments
 (0)