Simplify logic #4471 (#4472)

* Simplify logic #4471

* Swallow and log errors

Author: soulgalore

lib/plugins/s3/limit.js

@@ -1,34 +1,18 @@
-export async function runWithConcurrencyLimit(tasks, limit) {
-  const running = new Set();
-
-  async function runNext() {
-    if (tasks.length === 0) {
-      return;
-    }
-
-    const task = tasks.shift();
-    const promise = task()
-      .catch(error => {
-        throw error;
-      })
-      .finally(() => {
-        running.delete(promise);
-        void runNext();
-      });
+import { getLogger } from '@sitespeed.io/log';
+const log = getLogger('sitespeedio.plugin.s3');
 
-    running.add(promise);
-    if (running.size < limit) {
-      void runNext();
+export async function runWithConcurrencyLimit(tasks, limit) {
+  async function worker() {
+    while (tasks.length > 0) {
+      const task = tasks.shift();
+      try {
+        await task();
+      } catch (error) {
+        log.error('Could not finish upload task', error);
+      }
     }
   }
 
-  const starters = [];
-  for (let index = 0; index < limit && tasks.length > 0; index++) {
-    starters.push(runNext());
-  }
-
-  await Promise.allSettled(starters);
-  if (running.size > 0) {
-    await Promise.allSettled(Array.from(running));
-  }
+  const workers = Array.from({ length: limit }, () => worker());
+  await Promise.all(workers);
 }