Skip to content

ConfiguredController behavior #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snowdrop-bot opened this issue Sep 23, 2021 · 0 comments
Closed

ConfiguredController behavior #43

snowdrop-bot opened this issue Sep 23, 2021 · 0 comments

Comments

@snowdrop-bot
Copy link

I see that the ConfiguredController has an init method in which does:

@Override
public void init(EventSourceManager eventSourceManager) {
  this.manager = eventSourceManager;
  controller.init(eventSourceManager);
}

So the underlying controller is initialized with the manager that is passed as an argument. But then the start method does something similar:

try {
  DefaultEventSourceManager<R> eventSourceManager = new DefaultEventSourceManager<>(this);
  controller.init(eventSourceManager);
} catch (MissingCRDException e) {
  throwMissingCRDException(crdName, specVersion, controllerName);
}

Wonder if this is correct or if this lead the controller to be initialized with two different event source manager.


operator-framework#554


$upstream:554$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants