Skip to content

reserved identifier violation #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elfring opened this issue Apr 14, 2015 · 5 comments
Closed

reserved identifier violation #6

elfring opened this issue Apr 14, 2015 · 5 comments

Comments

@elfring
Copy link

elfring commented Apr 14, 2015

I would like to point out that identifiers like "__SIO_CLIENT__H__" and "__SIO_MESSAGE_H__" do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

@melode11
Copy link
Contributor

@elfring what is your suggestion?

@elfring
Copy link
Author

elfring commented Apr 14, 2015

How do you think about to read corresponding information sources that describe the consequences of underscores in such identifiers?

@melode11
Copy link
Contributor

Thanks for your suggestion, I'll consider to have a patch for coding style improvement.
There are quite a lot of double underscore prefixed function names around the code, may breaks the rule.
For this case, __SIO_CLIENT_H__ are macros automatically generated by QT creator.

@melode11
Copy link
Contributor

29e82a6 fix those code style issues.

@elfring
Copy link
Author

elfring commented Apr 15, 2015

Thanks for your small source code improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants