Tweak logging and cli

Author: ryoqun

core/src/banking_trace.rs

@@ -216,6 +216,10 @@ impl BankingTracer {
         })
     }
 
+    pub fn is_enabled(&self) -> bool {
+        self.enabled_tracer.is_some()
+    }
+
     fn create_channel(&self, label: ChannelLabel) -> (BankingPacketSender, BankingPacketReceiver) {
         Self::channel(
             label,

core/src/validator.rs

@@ -937,6 +937,14 @@ impl Validator {
                 config.banking_trace_dir_byte_limit,
             )))
             .map_err(|err| format!("{} [{:?}]", &err, &err))?;
+        if banking_tracer.is_enabled() {
+            info!(
+                "Enabled banking tracer (dir_byte_limit: {})",
+                config.banking_trace_dir_byte_limit
+            );
+        } else {
+            info!("Disabled banking tracer");
+        }
 
         let (replay_vote_sender, replay_vote_receiver) = unbounded();
         let tvu = Tvu::new(

validator/src/cli.rs

@@ -1310,7 +1310,7 @@ pub fn app<'a>(version: &'a str, default_args: &'a DefaultArgs) -> App<'a, 'a> {
                 // expose friendly alternative name to cli than internal
                 // implementation-oriented one
                 .long("enable-banking-trace")
-                .value_name("MAX_BYTES")
+                .value_name("BYTES")
                 .validator(is_parsable::<DirByteLimit>)
                 .takes_value(true)
                 // Firstly, zero limit value causes tracer to be disabled