fix "Find references" exception

Author: sqs

client/shared/src/util/rxjs/combineLatestOrDefault.ts

@@ -1,9 +1,18 @@
 /* eslint-disable @typescript-eslint/no-use-before-define */
 /* eslint rxjs/no-internal: warn */
-import { Observable, ObservableInput, of, Operator, PartialObserver, Subscriber, TeardownLogic, zip } from 'rxjs'
-import { fromArray } from 'rxjs/internal/observable/fromArray'
+import {
+    asapScheduler,
+    from,
+    Observable,
+    ObservableInput,
+    of,
+    Operator,
+    PartialObserver,
+    Subscriber,
+    TeardownLogic,
+    zip,
+} from 'rxjs'
 import { OuterSubscriber } from 'rxjs/internal/OuterSubscriber'
-import { asap } from 'rxjs/internal/scheduler/asap'
 import { subscribeToResult } from 'rxjs/internal/util/subscribeToResult'
 
 /**
@@ -41,7 +50,7 @@ export function combineLatestOrDefault<T>(observables: ObservableInput<T>[], def
             // Only one source observable: no need to handle emission accumulation or default values
             return zip(...observables)
         default:
-            return fromArray(observables).lift(new CombineLatestOperator(defaultValue))
+            return from(observables).lift(new CombineLatestOperator(defaultValue))
     }
 }
 
@@ -103,7 +112,7 @@ class CombineLatestSubscriber<T> extends OuterSubscriber<T, T[]> {
         // This makes tests (using expectObservable) easier to write.
         if (!this.scheduled) {
             this.scheduled = true
-            asap.schedule(() => {
+            asapScheduler.schedule(() => {
                 if (this.scheduled && this.destination.next) {
                     this.destination.next(this.values.slice())
                 }

client/web/dev/esbuild/build.ts

@@ -34,6 +34,13 @@ export const BUILD_OPTIONS: esbuild.BuildOptions = {
         manifestPlugin,
         packageResolutionPlugin({
             path: require.resolve('path-browserify'),
+
+            // Needed because imports of rxjs/internal/... actually import a different variant of
+            // rxjs in the same package, which leads to observables from combineLatestOrDefault (and
+            // other places that use rxjs/internal/...) not being cross-compatible. See
+            // https://stackoverflow.com/questions/53758889/rxjs-subscribeto-js-observable-check-works-in-chrome-but-fails-in-chrome-incogn.
+            'rxjs/internal/OuterSubscriber': require.resolve('rxjs/_esm5/internal/OuterSubscriber'),
+            'rxjs/internal/util/subscribeToResult': require.resolve('rxjs/_esm5/internal/util/subscribeToResult'),
         }),
         monacoPlugin(MONACO_LANGUAGES_AND_FEATURES),
         {