Skip to content

Commit 95e4916

Browse files
Load images (#1649)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 parent 4336a5b commit 95e4916

File tree

5 files changed

+28
-8
lines changed
  • spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/leader
  • spring-cloud-kubernetes-integration-tests/spring-cloud-kubernetes-fabric8-client-istio/src/test/java/org/springframework/cloud/kubernetes/fabric8/client/istio
  • spring-cloud-kubernetes-test-support/src/main

5 files changed

+28
-8
lines changed

spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/leader/LeaderInitiator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ public void start() {
6363
hostPodWatcher.start();
6464
scheduledExecutorService = Executors.newSingleThreadScheduledExecutor();
6565
scheduledExecutorService.scheduleAtFixedRate(leadershipController::update,
66-
leaderProperties.getUpdatePeriod().toMillis(),
67-
leaderProperties.getUpdatePeriod().toMillis(), TimeUnit.MILLISECONDS);
66+
leaderProperties.getUpdatePeriod().toMillis(), leaderProperties.getUpdatePeriod().toMillis(),
67+
TimeUnit.MILLISECONDS);
6868
isRunning = true;
6969
}
7070
}

spring-cloud-kubernetes-integration-tests/spring-cloud-kubernetes-fabric8-client-istio/src/test/java/org/springframework/cloud/kubernetes/fabric8/client/istio/Fabric8IstioIT.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,9 @@ static void beforeAll() throws Exception {
6565
Commons.validateImage(IMAGE_NAME, K3S);
6666
Commons.loadSpringCloudKubernetesImage(IMAGE_NAME, K3S);
6767

68-
Images.loadIstioctl(K3S);
68+
Images.loadIstioCtl(K3S);
69+
Images.loadIstioProxyV2(K3S);
70+
Images.loadIstioPilot(K3S);
6971

7072
processExecResult(K3S.execInContainer("sh", "-c", "kubectl create namespace istio-test"));
7173
processExecResult(

spring-cloud-kubernetes-test-support/src/main/java/org/springframework/cloud/kubernetes/integration/tests/commons/Images.java

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,15 @@ public final class Images {
3636

3737
private static final String ISTIOCTL = "istio/istioctl";
3838

39-
private static final String ISTIOCTL_TAR = ISTIOCTL.replace('/', '-') + ":" + istioctlVersion();
39+
private static final String ISTIOCTL_TAR = ISTIOCTL.replace('/', '-') + ":" + istioVersion();
40+
41+
private static final String ISTIO_PROXY_V2 = "istio/proxyv2";
42+
43+
private static final String ISTIO_PROXY_V2_TAR = ISTIO_PROXY_V2.replace('/', '-') + ":" + istioVersion();
44+
45+
private static final String ISTIO_PILOT = "istio/istioctl";
46+
47+
private static final String ISTIO_PILOT_TAR = ISTIO_PILOT.replace('/', '-') + ":" + istioVersion();
4048

4149
private static final String KAFKA = "confluentinc/cp-kafka";
4250

@@ -54,7 +62,7 @@ public static String busyboxVersion() {
5462
return imageVersion(BUSYBOX);
5563
}
5664

57-
public static String istioctlVersion() {
65+
public static String istioVersion() {
5866
return imageVersion(ISTIOCTL);
5967
}
6068

@@ -78,8 +86,16 @@ public static void loadWiremock(K3sContainer container) {
7886
Commons.load(container, WIREMOCK_TAR, WIREMOCK, wiremockVersion());
7987
}
8088

81-
public static void loadIstioctl(K3sContainer container) {
82-
Commons.load(container, ISTIOCTL_TAR, ISTIOCTL, istioctlVersion());
89+
public static void loadIstioCtl(K3sContainer container) {
90+
Commons.load(container, ISTIOCTL_TAR, ISTIOCTL, istioVersion());
91+
}
92+
93+
public static void loadIstioProxyV2(K3sContainer container) {
94+
Commons.load(container, ISTIO_PROXY_V2_TAR, ISTIO_PROXY_V2, istioVersion());
95+
}
96+
97+
public static void loadIstioPilot(K3sContainer container) {
98+
Commons.load(container, ISTIO_PILOT_TAR, ISTIO_PILOT, istioVersion());
8399
}
84100

85101
public static void loadKafka(K3sContainer container) {

spring-cloud-kubernetes-test-support/src/main/java/org/springframework/cloud/kubernetes/integration/tests/commons/fabric8_client/Util.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ public void setUpIstioctl(String namespace, Phase phase) {
267267

268268
String imageWithoutVersion = istioctlDeployment.getSpec().getTemplate().getSpec().getContainers().get(0)
269269
.getImage();
270-
String imageWithVersion = imageWithoutVersion + ":" + Images.istioctlVersion();
270+
String imageWithVersion = imageWithoutVersion + ":" + Images.istioVersion();
271271
istioctlDeployment.getSpec().getTemplate().getSpec().getContainers().get(0).setImage(imageWithVersion);
272272

273273
if (phase.equals(Phase.CREATE)) {
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
busybox:1.36.1
22
istio/istioctl:1.20.5
3+
istio/proxyv2:1.20.5
4+
istio/pilot:1.20.5
35
confluentinc/cp-kafka:7.2.1
46
rabbitmq:3-management
57
wiremock/wiremock:3.4.2

0 commit comments

Comments
 (0)