Refresh token should not be issued if client is not configured with refresh_token grant type#155 #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efresh_token grant type spring-projects#155
spring-projects-issues
added
the
status: waiting-for-triage
|
Hi, This issue seems to be a fault of mine not often working with GitHub. My pull request that solves #155 created this as a new issue. Sorry for this problem. This should be closed as a duplicate. However, I'm not sure. Is it enough to use the same name for the commit to the issue for this problem not to happen again? |
alek-sys
reviewed
Dec 1, 2020
...auth2/server/authorization/authentication/OAuth2AuthorizationCodeAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
jgrandja
requested changes
Dec 3, 2020
There was a problem hiding this comment.
Thanks for the PR @lspil !
Just so you are aware of the PR process, after you submit a PR it does create a new type of issue and therefore resulting in 2 issues - the original issue and the PR issue. This is the normal process. After we merge the PR, we will close it and label as a duplicate.
...auth2/server/authorization/authentication/OAuth2AuthorizationCodeAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...auth2/server/authorization/authentication/OAuth2AuthorizationCodeAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/security/oauth2/server/authorization/client/TestRegisteredClients.java
Outdated
Show resolved
Hide resolved
jgrandja
added
type: bug
…efresh_token grant type#155
doba16
pushed a commit
to doba16/spring-authorization-server
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refresh token was generated even if the client didn't have the refresh token grant type assigned.
The refresh token is now generated only for a client registered for the refresh token grant type.
Closes gh-155