Redirect URI validation for loopback address #244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jgrandja
requested changes
Mar 15, 2021
There was a problem hiding this comment.
Thanks for the PR @anoopgarlapati ! Please see review comments.
...ingframework/security/oauth2/server/authorization/web/OAuth2AuthorizationEndpointFilter.java
Outdated
Show resolved
Hide resolved
...ingframework/security/oauth2/server/authorization/web/OAuth2AuthorizationEndpointFilter.java
Outdated
Show resolved
Hide resolved
...ingframework/security/oauth2/server/authorization/web/OAuth2AuthorizationEndpointFilter.java
Outdated
Show resolved
Hide resolved
...ingframework/security/oauth2/server/authorization/web/OAuth2AuthorizationEndpointFilter.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/security/oauth2/server/authorization/client/TestRegisteredClients.java
Outdated
Show resolved
Hide resolved
...amework/security/oauth2/server/authorization/web/OAuth2AuthorizationEndpointFilterTests.java
Outdated
Show resolved
Hide resolved
...amework/security/oauth2/server/authorization/web/OAuth2AuthorizationEndpointFilterTests.java
Outdated
Show resolved
Hide resolved
...amework/security/oauth2/server/authorization/web/OAuth2AuthorizationEndpointFilterTests.java
Outdated
Show resolved
Hide resolved
jgrandja
added
type: enhancement
Modified redirect_uri validation as per OAuth 2.1 to accomodate for redirections on loopback address interface. Closes spring-projectsgh-243.
anoopgarlapati
force-pushed
the
loopback-redirection
branch
from
501adb0 to
03f1972
Compare
|
Thanks for the PR @anoopgarlapati ! This is now in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified redirect_uri validation as per OAuth 2.1 to
accomodate for redirections on loopback address interface.
Closes gh-243.