Skip to content

Consider adding a switch to disable JMX completely #16674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snicoll opened this issue Apr 27, 2019 · 1 comment
Closed

Consider adding a switch to disable JMX completely #16674

snicoll opened this issue Apr 27, 2019 · 1 comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply theme: performance Issues related to general performance type: enhancement A general enhancement

Comments

@snicoll
Copy link
Member

snicoll commented Apr 27, 2019

Right now, spring.jmx.enabled is about our own support, i.e. detecting a custom MBeanServer and exposing relevant beans in the context as well as switching things specific (connection pool handling).

There are other components that touches the MBeanServer directly, Tomcat being the most prominent example but not the only one. #16498 is going to handle Tomcat with the introduction of a specific property to switch that on if our own support is off.

This one is about researching the idea of extending the switch to things that we know and that exposes things to JMX by default so that they don't if JMX support is disabled.

@snicoll snicoll added the status: waiting-for-triage An issue we've not yet triaged label Apr 27, 2019
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 20, 2019
@philwebb philwebb added this to the 2.x milestone Dec 20, 2019
@philwebb philwebb added the theme: performance Issues related to general performance label Dec 20, 2019
@philwebb philwebb modified the milestones: 2.x, 3.x Aug 19, 2022
@snicoll
Copy link
Member Author

snicoll commented Aug 7, 2024

This hasn't moved in 5 years and nobody seemed to be interested by the idea. Looking at the outcome of #16498, I don't think we should pursue this.

@snicoll snicoll closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2024
@snicoll snicoll added the status: declined A suggestion or change that we don't feel we should currently apply label Aug 7, 2024
@snicoll snicoll removed this from the 3.x milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply theme: performance Issues related to general performance type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants